Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: retry init app connection #197

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Conversation

JettTech
Copy link
Contributor

@JettTech JettTech commented Aug 2, 2024

This adds a catch case for whenever the identified app connection is down or unable to be established. Whenever that happens this attempts to create a new app interface connection a single time, and if that fails, then it throws the ws error as before.

@JettTech JettTech requested a review from zo-el as a code owner August 2, 2024 19:12
zo-el
zo-el previously approved these changes Aug 5, 2024
Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update your description? Because it looks like the implementation is different than the description

@JettTech
Copy link
Contributor Author

JettTech commented Aug 5, 2024

@zo-el - updated the approach

zo-el
zo-el previously approved these changes Aug 5, 2024
@JettTech JettTech requested a review from zo-el August 5, 2024 23:16
@JettTech JettTech merged commit 8ef139c into main Aug 6, 2024
2 checks passed
@JettTech JettTech deleted the fix-retry-init-app-connection branch August 6, 2024 04:46
mattgeddes pushed a commit that referenced this pull request Aug 19, 2024
This adds a catch case for whenever the identified app connection is
down or unable to be established. Whenever that happens this attempts to
create a new app interface connection a single time, and if that fails,
then it throws the ws error as before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants