Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Avoid duplicate app interface creation + clean-up #192

Merged
merged 7 commits into from
Jul 16, 2024

Conversation

JettTech
Copy link
Contributor

@JettTech JettTech commented Jul 14, 2024

Updates:

  • Renames HHAAgent to CoreAppAgent
  • Adds the clone trait to CoreAppAgent and HfAgent.
  • Adds check in AppConnection.connect() to avoid attaching new app interfaces for app interfaces that already exist

NB: This is needed in holo-matching-services
matching services pr: https://github.com/Holo-Host/holo-matching-services/pull/53

@JettTech JettTech requested a review from zo-el as a code owner July 14, 2024 21:35
@JettTech JettTech changed the title Add clone trait to app connection structs Fix/Avoid duplicate app interface creation + clean-up Jul 16, 2024
@JettTech
Copy link
Contributor Author

@zo-el - CI tests are failing the the devNet and alphaNet runs of the run_configure_holochain test due an error fetching the membrane proof from the memproof server. The call to the memproof server is responding with a 502 (Bad Gateway) error. This error seems to be intermittently occurring across multiple PRs. NB: It is passing on the read-only memproof test of the same function.

Do you have any ideas about what is causing the memproof server to return this error? If not, I can just bring this issue up at PL tomorrow.

Also, with all this in mind, this PR is ready for your review.

Copy link
Member

@zo-el zo-el left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, small reminder to update all println to debug logs

@JettTech JettTech requested a review from zo-el July 16, 2024 16:23
@JettTech JettTech merged commit 9e5853c into main Jul 16, 2024
2 checks passed
@JettTech JettTech deleted the feat/clone-app-connection branch July 16, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants