[BUG] A generic error occurred in GDI+. at GetHicon Load_Tick (#361),…

… version 1.2.8.4
Hofknecht · Feb 20, 2022 · eaf755e · eaf755e
1 parent 7256910
commit eaf755e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/Properties/AssemblyInfo.cs b/Properties/AssemblyInfo.cs
@@ -39,5 +39,5 @@
 // You can specify all the values or you can default the Build and Revision Numbers
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("1.2.8.3")]
-[assembly: AssemblyFileVersion("1.2.8.3")]
+[assembly: AssemblyVersion("1.2.8.4")]
+[assembly: AssemblyFileVersion("1.2.8.4")]
diff --git a/UserInterface/AppNotifyIcon.cs b/UserInterface/AppNotifyIcon.cs
@@ -84,12 +84,15 @@ private void Load_Tick(object sender, EventArgs e)
         {
             if (threadsLoading)
             {
-                rotationAngle += 5;
-                using Bitmap bitmapLoading = Resources.StaticResources.LoadingIcon.ToBitmap();
-                using Bitmap bitmapLoadingRotated = new(ImagingHelper.RotateImage(bitmapLoading, rotationAngle));
-                IntPtr hIcon = bitmapLoadingRotated.GetHicon();
-                notifyIcon.Icon = (Icon)Icon.FromHandle(hIcon).Clone();
-                DllImports.NativeMethods.User32DestroyIcon(hIcon);
+                notifyIcon.Icon = Resources.StaticResources.LoadingIcon;
+
+                // see #361, rotating icon caused rare GDI+ exception at GetHicon
+                // rotationAngle += 5;
+                // using Bitmap bitmapLoading = Resources.StaticResources.LoadingIcon.ToBitmap();
+                // using Bitmap bitmapLoadingRotated = new(ImagingHelper.RotateImage(bitmapLoading, rotationAngle));
+                // IntPtr hIcon = bitmapLoadingRotated.GetHicon();
+                // notifyIcon.Icon = (Icon)Icon.FromHandle(hIcon).Clone();
+                // DllImports.NativeMethods.User32DestroyIcon(hIcon);
             }
             else
             {