Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webp support #5

Merged
merged 6 commits into from
May 5, 2022
Merged

Add webp support #5

merged 6 commits into from
May 5, 2022

Conversation

cemonel
Copy link
Contributor

@cemonel cemonel commented Apr 26, 2022

No description provided.

@@ -152,19 +152,18 @@ def info(path, args, customer):
return json_response(info)


def fetch_image(args, original_url, exists):
if args['with_info'] or args['force'] or not exists:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if check is redundant.
See line 181.

@yigitguler
Copy link
Member

Any thoughts @fergalwalsh?

Copy link
Contributor

@fergalwalsh fergalwalsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if imagemagick is handling webp fine then this should work.

@cemonel
Copy link
Contributor Author

cemonel commented Apr 27, 2022

Yes, Imagemagick handles the rest.
Before merging this I will add some tests for webp and also some minor documentation changes. Then we can merge this.

@cemonel cemonel added the ready label Apr 27, 2022
@cemonel cemonel requested a review from fergalwalsh April 27, 2022 15:41
@cemonel cemonel merged commit e26a7df into main May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants