Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow linux users to change HOST & PORT using env vars #33

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

ranjan-purbey
Copy link
Contributor

No description provided.

@HimbeersaftLP
Copy link
Owner

Thanks for the PR @ranjan-purbey , sorry for not responding for so long.
I'm not a big fan of them just being named HOST and PORT as they are very generic and I suspect people might use those for other programs that they use as well and that might cause confusion.
I've seen many projects use env vars prefixed with the project name instead.
Do you think that would be fine as well?

@ranjan-purbey
Copy link
Contributor Author

Yeah, I think that makes sense. What prefix should we use?

@HimbeersaftLP
Copy link
Owner

Maybe WEBINSPECTOR_?

@ranjan-purbey
Copy link
Contributor Author

Done @HimbeersaftLP

@HimbeersaftLP
Copy link
Owner

Thanks!

@HimbeersaftLP HimbeersaftLP merged commit 68b8fb7 into HimbeersaftLP:main Jan 17, 2025
@ranjan-purbey ranjan-purbey deleted the patch-1 branch January 17, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants