Extended Structs with more Information #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
HilkopterBob
changed the title
HilkopterBob
requested changes
Oct 1, 2024
HilkopterBob
requested changes
Oct 1, 2024
structs/structs.go
Outdated
| } | ||
|
|
||
| type Interface struct { | ||
| Name string | ||
| Ip_addr string | ||
| Gateway string | ||
| DNS_servers []string |
There was a problem hiding this comment.
There are no per Interface DNS Settings, see:
Server Fault
structs/structs.go
Outdated
| @@ -13,14 +18,13 @@ type Network_Info struct { | |||
| Mac_addr string | |||
| Domain string | |||
There was a problem hiding this comment.
Its a severe pain to set search domains on an per interface basis.
Can you add domain to NetworkInfos?
HilkopterBob
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extended Structs with the Following Informations:
Network_Info:
+ Gateway
+ DNS_servers
+ Netmask
+ Link_speed
+ Domain
Host
+ Uname
User
+ Group