enable net_size_check by default with different max sizes for c and cuda #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
developedby
requested changes
Jul 29, 2024
|
@developedby i resolve the issue. |
developedby
requested changes
Aug 7, 2024
developedby
requested changes
Aug 8, 2024
| Compiled | ||
| [4m[1m[31mErrors:[0m | ||
| [1mIn definition '[4mmain[0m[1m':[0m | ||
| Definition is too large for hvm (size=120002, max size=4095). Please break it into smaller pieces. |
There was a problem hiding this comment.
This is weird, it should be breaking this thing in pieces of the size we passed to the float_combinators pass (64, MAX_NET_SIZE_CUDA)
There was a problem hiding this comment.
I'll have a look into why this is later
|
You have to rerun the tessts and update the snapshots for you last changes |
|
@developedby updated the snapshots! |
|
Thank you so much! This has been bugging me for some time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #622