Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi line comment syntax #625

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Add multi line comment syntax #625

merged 4 commits into from
Jul 10, 2024

Conversation

imaqtkatt
Copy link
Contributor

No description provided.

@imaqtkatt imaqtkatt self-assigned this Jul 8, 2024
@imaqtkatt imaqtkatt requested a review from developedby July 8, 2024 16:56
@developedby
Copy link
Member

Closes #595

Copy link
Member

@developedby developedby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about #{ }#.
I understand why but it just looks so ugly.

@developedby
Copy link
Member

Every language does this differently, there isn't any common way to do it other than /* */.

If i were to choose, I'd go with #= =# like in julia, even if it doesn't look like it's opening a block, or with #[ ]# like in nim, even if we don't really use [ ] with this kind of meaning elsewhere.

Relevant: https://en.wikipedia.org/wiki/Comparison_of_programming_languages_(syntax)#Comment_comparison

Do you have any preference or reason for any of the options? If not, we'll keep #{ }#

@imaqtkatt
Copy link
Contributor Author

I slightly would prefer #{ ... #} over #{ ... }#, what do you think?

@developedby
Copy link
Member

developedby commented Jul 9, 2024

I slightly would prefer #{ ... #} over #{ ... }#, what do you think?

I like it

@developedby
Copy link
Member

Does this also fix #623 ?

@imaqtkatt
Copy link
Contributor Author

Yes, it does fix the issue

@imaqtkatt imaqtkatt added this pull request to the merge queue Jul 10, 2024
Merged via the queue into main with commit 6bbc223 Jul 10, 2024
5 checks passed
@imaqtkatt imaqtkatt deleted the multi-line-comments branch July 10, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants