Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release: 8.4.0 #2006

Merged
merged 66 commits into from
Nov 29, 2024
Merged

Release: 8.4.0 #2006

merged 66 commits into from
Nov 29, 2024

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Sep 25, 2024

Proposed Change

Placeholder PR for all v8.4.0 Changes

Type of change

What types of changes does your code introduce? Tick all that apply.

  • Bugfix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation-Only Update
  • Other (if none of the other choices apply)

Checklist

By opening this PR, I confirm that I have:

  • Ensured that the PR branch is in sync with the target branch (i.e. it is automatically merge-able)
  • Created or updated any tests if relevant
  • Have validated this change against the Test Plan
  • Requested a review by one of the repository maintainers
  • Have written new documentation or updated existing documentation to detail any new or updated functionality and how to use it
  • Have added an entry into the changelog

JFriel and others added 2 commits September 25, 2024 14:05
@JFriel
add changelog
2a516bf
@JFriel
Bugfix/rdmp 253 filter ordering (#2007)
53596b0 
* add start

* partial

* tidy up code

* filter updates

* update db migrations

* update correct db

* update changelog

* add base creation sql

* fix create

* tidy up
JFriel added 27 commits October 8, 2024 15:34
@JFriel
update insert
bfdc644
@JFriel
Merge branch 'develop' of https://github.com/HicServices/RDMP into re…
c2ce5d3 
…lease/8.4.0
@JFriel
tidy up
ca5a0b7
@JFriel
interim
e27fd8e
@JFriel
style updates
ece04aa
@JFriel
add some info
d1bcf49
@JFriel
start of where clause
0506490
@JFriel
improved
34457ba
@JFriel
improved dates
6475d5e
@JFriel
improve bookends
5ce3057
@JFriel
Merge branch 'develop' of https://github.com/HicServices/RDMP into re…
6edf05b 
…lease/8.4.0
@JFriel
Merge branch 'develop' of https://github.com/HicServices/RDMP into re…
80b03e7 
…lease/8.4.0
@JFriel
Merge branch 'release/8.4.0' of https://github.com/HicServices/RDMP i…
7e86428 
…nto bugfix/RDMP-256-migrate-composite-pk-issue
@JFriel
add changelog
2bf9ceb
@JFriel
update changelog
d8201c5
@JFriel
Merge branch 'develop' of https://github.com/HicServices/RDMP into sp…
b0f3388 
…ike/overview-generation
@JFriel
improve ui with frequency
cb41028
@JFriel
tidy up for tests
9885dc9
@JFriel
add summary
656cb6c
@JFriel
rename chart
1bd3e4e
@JFriel
interim people
40dd02e
@JFriel
add people label
ffcf62b
@JFriel
better where
80518c4
@JFriel
move items around
08b2ca1
@JFriel
fix up tests
4fe2f66
@JFriel
tidy up code
fdd9e28
@JFriel
tidy up
c8f89d0
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 25, 2024
View reviewed changes
Rdmp.Core/Curation/Data/Overview/OverviewModel.cs Fixed Show fixed Hide fixed
Rdmp.Core/Curation/Data/Overview/OverviewModel.cs Fixed Show fixed Hide fixed
Rdmp.Core/Curation/Data/Overview/OverviewModel.cs Fixed Show fixed Hide fixed
Rdmp.Core/Curation/Data/Overview/OverviewModel.cs

public Tuple<DateTime, DateTime> GetStartEndDates(ColumnInfo dateColumn, string whereClause)
{
DataTable dt = new();

Check warning

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'DataTable' is created but not disposed.
Rdmp.Core/Curation/Data/Overview/OverviewModel.cs
.Max(r => r.Field<DateTime>(dateColumn.Name));
var earliest = dt.AsEnumerable()
.Min(r => r.Field<DateTime>(dateColumn.Name));
dt = new();

Check warning

Code scanning / CodeQL

Missing Dispose call on local IDisposable Warning

Disposable 'DataTable' is created but not disposed.
Rdmp.UI/Overview/ViewCatalogueOverviewUI.cs Fixed Show fixed Hide fixed
Rdmp.UI/Overview/ViewCatalogueOverviewUI.cs Fixed Show fixed Hide fixed
Rdmp.UI/Overview/ViewCatalogueOverviewUI.cs Fixed Show fixed Hide fixed
Rdmp.UI/Overview/ViewCatalogueOverviewUI.cs Fixed Show fixed Hide fixed
Rdmp.UI/Overview/ViewCatalogueOverviewUI.cs Fixed Show fixed Hide fixed
JBaird00183 and others added 2 commits November 27, 2024 10:15
@JBaird00183 @dependabot
Changes made to popup buttons (#2076)
fcaef71 
* Changes made to popup buttons

* Bump the aws-sdk group with 4 updates (#2074)

Bumps the aws-sdk group with 4 updates: [AWSSDK.S3](https://github.com/aws/aws-sdk-net), [AWSSDK.SecurityToken](https://github.com/aws/aws-sdk-net), [AWSSDK.SSO](https://github.com/aws/aws-sdk-net) and [AWSSDK.SSOOIDC](https://github.com/aws/aws-sdk-net).


Updates `AWSSDK.S3` from 3.7.407 to 3.7.407.1
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Changelog](https://github.com/aws/aws-sdk-net/blob/main/SDK.CHANGELOG.MD)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

Updates `AWSSDK.SecurityToken` from 3.7.401.5 to 3.7.401.6
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Changelog](https://github.com/aws/aws-sdk-net/blob/main/SDK.CHANGELOG.MD)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

Updates `AWSSDK.SSO` from 3.7.400.56 to 3.7.400.57
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Changelog](https://github.com/aws/aws-sdk-net/blob/main/SDK.CHANGELOG.MD)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

Updates `AWSSDK.SSOOIDC` from 3.7.400.56 to 3.7.400.57
- [Release notes](https://github.com/aws/aws-sdk-net/releases)
- [Changelog](https://github.com/aws/aws-sdk-net/blob/main/SDK.CHANGELOG.MD)
- [Commits](https://github.com/aws/aws-sdk-net/commits)

---
updated-dependencies:
- dependency-name: AWSSDK.S3
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk
- dependency-name: AWSSDK.SecurityToken
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk
- dependency-name: AWSSDK.SSO
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk
- dependency-name: AWSSDK.SSOOIDC
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: aws-sdk
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update CHANGELOG.md

* Tidied up code

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@JFriel @jas88
Task/rdmp 32 regex redaction (#2009)
090097e 
* interim

* interim

* redact and add some tests

* add missing interface

* add regex redaction keys

* add helper

* add concept

* update interfaces

* add icons and fix restore

* add missing files

* add docs

* add regions

* add ignore

* add speed test

* improve speed

* improve speed

* update padding

* stress test

* add test case

* add fk names

* faster data load

* faster update

* more timers

* super fast redaction

* tidy up code

* woking keys

* improved

* add limiting

* shared helper

* shared

* interim

* working

* add summary

* restore tests working

* add tests

* start og ui update

* start of ui

* basic configuraion

* working add

* user interface

* update for tests

* update test

* tests

* tidy up

* updates

* fix merge

* ad dicons

* add missing icons

* tidyup

* fix tests

* add missing file

* update migration number

* add changelog

* add timeout

* fix build

* interim

* tidy up

* tidy up code

* add publish

* add todo

* add redact all

* add column

* update table

* add docs

* update markdown

* fix typo

* fix typos

* tidy up tests

* tidy up tests

* Include regex redaction doc in VS Solution file

* Update ExecuteCommandPerformRegexRedactionOnCatalogueTests.cs

Syntax cleanup

* Update ThrowImmediatelyActivator.cs

Remove obsolete comment

* Update ExecuteCommandPerformRegexRedactionOnCatalogueTests.cs

Start being green and recycling

* Update ExecuteCommandPerformRegexRedactionOnCatalogueTests.cs

Finish recycling test objects

---------

Co-authored-by: James A Sutherland <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 27, 2024
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@JFriel JFriel marked this pull request as ready for review November 29, 2024 09:22
@JFriel JFriel enabled auto-merge (squash) November 29, 2024 12:09
@JFriel JFriel merged commit b1457d0 into develop Nov 29, 2024
7 checks passed
@JFriel JFriel deleted the release/8.4.0 branch November 29, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdteviotdale rdteviotdale rdteviotdale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JFriel @rdteviotdale @jas88 @bpeacock001 @JBaird00183