Bump HIC.BadMedicine and Microsoft.Bcl.AsyncInterfaces #1824
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [HIC.BadMedicine](https://github.com/HicServices/BadMedicine) and [Microsoft.Bcl.AsyncInterfaces](https://github.com/dotnet/runtime). These dependencies needed to be updated together. Updates `HIC.BadMedicine` from 1.2.1 to 1.2.2 - [Release notes](https://github.com/HicServices/BadMedicine/releases) - [Changelog](https://github.com/HicServices/BadMedicine/blob/main/CHANGELOG.md) - [Commits](HicServices/SynthEHR@v1.2.1...v1.2.2) Updates `Microsoft.Bcl.AsyncInterfaces` from 6.0.0 to 7.0.0 - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v6.0.0...v7.0.0) --- updated-dependencies: - dependency-name: HIC.BadMedicine dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: Microsoft.Bcl.AsyncInterfaces dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
bot
added
.NET
|
Looks like these dependencies are no longer a dependency, so this is no longer needed. |
|
@JFriel the obsolete AsyncInterfaces one was noted as "Add Microsoft.Bcl.AsyncInterfaces 6.0.0 for plugin dependancy tree", Dependabot seems to think it's somehow related to BadMedicine/SynthEHR and the new version needs 7.0.0 not 6.0.0? |
It's odd it thinks it's SynthEHR related. It's actually backfilling for fo-dicom, which still expects 6.0.0. Don't think we want to bump Microsoft.Bcl.AsyncInterfaces, so once fo-dicom is updated we should be able to just remove this dependancy |
|
@JFriel ah yes - fo-dicom has that as an explicit dependency, so us referencing fo-dicom directly should avoid the need for that. (Plus we're bundling RdmpDicom as a plugin anyway, which already has that as a dependency.) |
|
@jas88 This might need a bit of investigation, as I've just tried removing the Microsoft.Bcl.AsyncInterfaces from the RDMP.Core dependencies and it causes issues with Microsoft.Bcl.AsyncInterfaces not being available |
|
@JFriel Did you still get that issue after replacing the AsyncInterfaces reference with a reference to fo-dicom? The latter should automatically include AsyncInterfaces for you, so if that doesn't work something is broken somewhere in nupkg land... |
|
@jas88 No, just removed AsyncInterface without replacing it. Not sure we should be including a reference to fo-dicom in Rdmp.Core , but may be part of the wider plugin conversation |
Bumps HIC.BadMedicine and Microsoft.Bcl.AsyncInterfaces. These dependencies needed to be updated together.
Updates
HIC.BadMedicinefrom 1.2.1 to 1.2.2Release notes
Sourced from HIC.BadMedicine's releases.
Changelog
Sourced from HIC.BadMedicine's changelog.
Commits
48d3ad6Bump CsvHelper from 32.0.2 to 32.0.36919fe8bump to 1.2.2 and add deprication warning (#196)01d3f87Bump YamlDotNet from 15.1.2 to 15.1.46de7d7bBump CsvHelper from 32.0.1 to 32.0.21fc9febBump CsvHelper from 31.0.4 to 32.0.197d7f98Bump NUnit.Analyzers from 4.1.0 to 4.2.067e72bcBump CsvHelper from 31.0.3 to 31.0.482e2319Bump CsvHelper from 31.0.2 to 31.0.3Updates
Microsoft.Bcl.AsyncInterfacesfrom 6.0.0 to 7.0.0Release notes
Sourced from Microsoft.Bcl.AsyncInterfaces's releases.
... (truncated)
Commits
d099f07Merge in 'release/7.0' changes0cee4aa[release/7.0] Fix loading app-local ICU (#77118)bebb595Merge in 'release/7.0' changescd2d837Port stackoverflow fix from Roslyn to SourceGenerator PolyFill (#76954)db34250Merge in 'release/7.0' changesf252bc6Merged PR 26705: Empty to commit to diverge internal and public branches075e74e[mono][s390x] Fix wrong implementation of OP_CHECK_THIS (#76920)aacc243Update macos-11 vmImage to macos-12 for XCode 14. (#76973)c7b59fc[release/7.0] Reintroduce typo in ICorDebug public API names (#76967)156aa8aMerge in 'release/7.0' changesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)