Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/fix up rc4 #1626

Closed
wants to merge 43 commits into from
Closed

task/fix up rc4 #1626

wants to merge 43 commits into from

Conversation

JFriel
Copy link
Collaborator

@JFriel JFriel commented Sep 18, 2023

  • Typo and syntax fixes
  • syntax fixes
  • Remove CheckForVersionMismatches, no longer needed
  • Update DocumentationCrossExaminationTest.cs
  • Update DatabaseTests.cs
  • Fix flatfileattacher circularity
  • Test typo fixes
  • Syntax cleanups
  • Create directory.build.props
  • Fix plugin version check code
  • Better plugin load failure debugging
  • Better plugin load error reporting
  • Plugin work
  • Update ExecuteCommandPrunePlugin.cs
  • Update ExecuteCommandPrunePlugin.cs
  • Update Startup.cs
  • Update LoadModuleAssembly.cs
  • Syntax tidy, simplify PersistStringHelper
  • Syntax, duplicate dictionary lookups
  • Booleans and args.Empty
  • Fix infinite loop in time window checker, LINQ cleanup
  • Tidy up ObjectConstructor and usage
  • Syntax, pattern matching
  • Compile fix, remove redundancies
  • Syntax cleanups
  • Final syntax cleanup
  • Redundancies, unnecessary generics
  • Build and syntax fixes
  • Tune ColumnForbidder
  • Fix Microsoft.NET.Test.Sdk versioning
  • System.Resources.Extensions version mismatch
  • API and naming fixups
  • Update DatabaseTests.cs
  • ANOTable recursion fix
  • Update DatabaseTests.cs
  • Update DatabaseTests.cs
  • Update UnitTests.cs
  • Adjust docs, date bound checking, validation serialisation
  • Cleanup, better logging in startup reflection
  • RC4
  • String interp
  • Syntax, pattern matching
  • Make IgnoreAllErrorsCheckNotifier singleton, fix MEF event issue
  • Update IgnoreAllErrorsCheckNotifier.cs
  • Syntax clean
  • Fixup ThrowImmediatelyCheckNotifier.Quiet()
  • Remove unit test for obsolete method
  • Refactor MEF
  • Update ConsoleInputManager.cs
  • Syntax, MEF
  • Syntax
  • Update ProposeExecutionWhenTargetIsLoadStageNode.cs
  • Type checking fix
  • MEF caching, distincting
  • Syntax clean
  • Regexes, .Net 7
  • API fixup for .Net 7 internal changes
  • Prune all non-DLLs in plugins
  • Syntax cleaning
  • Cleanup
  • Pattern matching
  • Coalesce
  • Update ExecuteCommandPrunePlugin.cs
  • Cleanup, dependency update
  • Cleanup
  • MEF adjustments
  • Fix Lazy MEF init
  • Update QueryCachingCrossServerTests.cs
  • Compound assignments
  • Syntax
  • Dictionary
  • Null propogation
  • Null coalesce
  • Regexes
  • Docs fixup
  • Syntax cleanup, remove old DWM check (Win7 only)
  • Tidy XML handling
  • Whitespace cleanup
  • Update DbDataCommandDataFlowSource.cs
  • Update Packages.md
  • Update RDMPConcept.cs
  • Update DataLoadInfo.cs
  • Dispose of MEF references everywhere
  • Update WebFileDownloader.cs
  • Update ResearchDataManagementPlatform.csproj
  • Post merge cleanup - duplicate lines, statics, inlining variables
  • Add Equ, remote old Xam settings plugin
  • Update LogManager.cs
  • Specify string comparison locale
  • Update Startup.cs
  • Update LoadModuleAssembly.cs
  • Update IPluginManager.cs
  • Static methods where applicable
  • Remove SetupMEF, no longer needed
  • More readonly fields
  • Whitespace and typo fixes
  • Update UsefulStuff.cs
  • Statics, readonly
  • Format fixups
  • Pattern matching
  • Whitespace, sealed classes
  • Format, auto cleanup
  • Docs fixup; allow non-public constructors for reflection-invoked classes
  • Static and string cleanup
  • Typos and string diff fixups
  • Update DataFlowPipelineContext.cs
  • Make ProgressLog timeout 1 hour - insane for single-row inserts, but 2 minutes is still too short...
  • Update plugin pack to install to right place
  • Move Terminal.Gui to Core rather than duplicating both CLI and GUI refs
  • Implement async writer thread for ProgressLog
  • Flush log queue unconditionally, even on duplicate DataLoadInfo closes.
  • Bugfix: load Win code only in GUI mode, instead of whenever running in WinNT
  • Disused files
  • Add alias for mistyped Nullity predictor
  • Stray newline
  • Update ValuePredictsOtherValueNullity.cs
  • Format cleanup
  • Tidyup
  • feature/rc4 cleanup (feature/rc4 cleanup #1608)
  • bugfix/RDMP 31 extraction delect ui issue (bugfix/RDMP 31 extraction delect ui issue #1609)
  • Task/rdmp 35 merge develop into rc4 (Task/rdmp 35 merge develop into rc4 #1613)
  • Fix regression in ThrowImmediatelyDataLoadEventListener calls
  • Typo, var, covariance/contravariance
  • Bump Terminal.Gui from 1.13.1 to 1.13.4
  • Merge pull request Bump Terminal.Gui from 1.13.1 to 1.13.4 #1582 from HicServices/dependabot/nuget/develop/Terminal.Gui-1.13.4
  • Bump Terminal.Gui from 1.13.4 to 1.13.5
  • Merge pull request Bump Terminal.Gui from 1.13.4 to 1.13.5 #1584 from HicServices/dependabot/nuget/develop/Terminal.Gui-1.13.5
  • Bump svenstaro/upload-release-action from 2.6.1 to 2.7.0
  • Merge pull request Bump svenstaro/upload-release-action from 2.6.1 to 2.7.0 #1585 from HicServices/dependabot/github_actions/svenstaro/upload-release-action-2.7.0
  • Bump NLog from 5.2.2 to 5.2.3
  • Bump Microsoft.NET.Test.Sdk from 17.6.3 to 17.7.0

dependabot bot and others added 30 commits July 20, 2023 00:39
Bumps [Terminal.Gui](https://github.com/gui-cs/Terminal.Gui) from 1.13.1 to 1.13.4.
- [Release notes](https://github.com/gui-cs/Terminal.Gui/releases)
- [Commits](gui-cs/Terminal.Gui@v1.13.1...v1.13.4)

---
updated-dependencies:
- dependency-name: Terminal.Gui
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [Terminal.Gui](https://github.com/gui-cs/Terminal.Gui) from 1.13.4 to 1.13.5.
- [Release notes](https://github.com/gui-cs/Terminal.Gui/releases)
- [Commits](gui-cs/Terminal.Gui@v1.13.4...v1.13.5)

---
updated-dependencies:
- dependency-name: Terminal.Gui
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [svenstaro/upload-release-action](https://github.com/svenstaro/upload-release-action) from 2.6.1 to 2.7.0.
- [Release notes](https://github.com/svenstaro/upload-release-action/releases)
- [Changelog](https://github.com/svenstaro/upload-release-action/blob/master/CHANGELOG.md)
- [Commits](svenstaro/upload-release-action@2.6.1...2.7.0)

---
updated-dependencies:
- dependency-name: svenstaro/upload-release-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [NLog](https://github.com/NLog/NLog) from 5.2.2 to 5.2.3.
- [Release notes](https://github.com/NLog/NLog/releases)
- [Changelog](https://github.com/NLog/NLog/blob/dev/CHANGELOG.md)
- [Commits](NLog/NLog@v5.2.2...v5.2.3)

---
updated-dependencies:
- dependency-name: NLog
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.6.3 to 17.7.0.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.6.3...v17.7.0)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
* Automated formatting and syntax clean
* Match docs to source; whitespace unit test cleanup
Bumps [Moq](https://github.com/moq/moq) from 4.18.4 to 4.20.1.
- [Release notes](https://github.com/moq/moq/releases)
- [Changelog](https://github.com/moq/moq/blob/main/CHANGELOG.md)
- [Commits](moq/moq.spikes@v4.18.4...v4.20.1)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [shogo82148/actions-setup-perl](https://github.com/shogo82148/actions-setup-perl) from 1.23.0 to 1.23.1.
- [Release notes](https://github.com/shogo82148/actions-setup-perl/releases)
- [Commits](shogo82148/actions-setup-perl@v1.23.0...v1.23.1)

---
updated-dependencies:
- dependency-name: shogo82148/actions-setup-perl
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
* make external serverremovable

* no longer throwing out errors

* add catalogue fix

* added todo reminder

* working startup option

* remove fk drop

* fix creation issue

* add todo

* working delete

* invert checkbox ui

* add throw for unexpected no logging server

* rename variables to match descriptions

* fix bad merge

* fix autosave issue
Bumps [Moq](https://github.com/moq/moq) from 4.20.1 to 4.20.2.
- [Release notes](https://github.com/moq/moq/releases)
- [Changelog](https://github.com/moq/moq/blob/main/CHANGELOG.md)
- [Commits](moq/moq.spikes@v4.20.1...v4.20.2)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
* Add Clear User Settings button, command and unit test
* Update SelfCertifyingDataAccessPoint.cs - Fix typo


---------

Co-authored-by: jas88 <[email protected]>
Bumps [Moq](https://github.com/moq/moq) from 4.20.2 to 4.20.69.
- [Release notes](https://github.com/moq/moq/releases)
- [Changelog](https://github.com/moq/moq/blob/main/CHANGELOG.md)
- [Commits](moq/moq.spikes@v4.20.2...v4.20.69)

---
updated-dependencies:
- dependency-name: Moq
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.0.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3.7.0...v3.8.0)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 13.1.1 to 13.2.0.
- [Release notes](https://github.com/aaubry/YamlDotNet/releases)
- [Commits](aaubry/YamlDotNet@v13.1.1...v13.2.0)

---
updated-dependencies:
- dependency-name: YamlDotNet
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [SixLabors.ImageSharp.Drawing](https://github.com/SixLabors/ImageSharp.Drawing) from 1.0.0-beta15 to 1.0.0.
- [Release notes](https://github.com/SixLabors/ImageSharp.Drawing/releases)
- [Commits](SixLabors/ImageSharp.Drawing@v1.0.0-beta15...v1.0.0)

---
updated-dependencies:
- dependency-name: SixLabors.ImageSharp.Drawing
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.8.0 to 3.8.1.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](actions/setup-node@v3.8.0...v3.8.1)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.7.0 to 17.7.1.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.7.0...v17.7.1)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [Autoupdater.NET.Official](https://github.com/ravibpatel/AutoUpdater.NET) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/ravibpatel/AutoUpdater.NET/releases)
- [Commits](ravibpatel/AutoUpdater.NET@v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: Autoupdater.NET.Official
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
* Update DataLoadInfo.cs - Implement worker thread for writing ProgressLog entries in background
---------

Co-authored-by: James A Sutherland <>
Co-authored-by: James Friel <[email protected]>
Bumps [VPKSoft.ScintillaLexers.NET](https://github.com/VPKSoft/ScintillaLexers) from 1.1.15 to 1.1.16.
- [Release notes](https://github.com/VPKSoft/ScintillaLexers/releases)
- [Commits](https://github.com/VPKSoft/ScintillaLexers/commits)

---
updated-dependencies:
- dependency-name: VPKSoft.ScintillaLexers.NET
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
* start to update tests

* compiling tests

* tidy up unused

* attempt to fix some tests

* update tests

* update ui tests

* remove moq

* fix up tests

* fix up test

* fix test

* update tests

* tidy up code

* backout incorrect change

---------

Co-authored-by: James A Sutherland <[email protected]>
* partial fix

* add row peaker update

* fix up whitespace

* add a lot of daat begin loads

* more data load

* fix typo
JFriel and others added 12 commits August 28, 2023 14:09
* add message length check

* fix tabbing

* fix codescan alert

* update max length and add env config

* attempt to allow RDMP_

* fix typo

* add codeql update

* Update ToLoggingDatabaseDataLoadEventListener.cs

Adjust string trimming logic, handle ultra-short limits, only parse the environment variable once instead of per logging, avoid double-lookup in OnProgress handler

---------

Co-authored-by: James A Sutherland <[email protected]>
Bumps [YamlDotNet](https://github.com/aaubry/YamlDotNet) from 13.2.0 to 13.3.1.
- [Release notes](https://github.com/aaubry/YamlDotNet/releases)
- [Commits](aaubry/YamlDotNet@v13.2.0...v13.3.1)

---
updated-dependencies:
- dependency-name: YamlDotNet
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.7.1 to 17.7.2.
- [Release notes](https://github.com/microsoft/vstest/releases)
- [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md)
- [Commits](microsoft/vstest@v17.7.1...v17.7.2)

---
updated-dependencies:
- dependency-name: Microsoft.NET.Test.Sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [SixLabors.ImageSharp](https://github.com/SixLabors/ImageSharp) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/SixLabors/ImageSharp/releases)
- [Commits](SixLabors/ImageSharp@v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: SixLabors.ImageSharp
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [Terminal.Gui](https://github.com/gui-cs/Terminal.Gui) from 1.13.5 to 1.14.0.
- [Release notes](https://github.com/gui-cs/Terminal.Gui/releases)
- [Commits](gui-cs/Terminal.Gui@v1.13.5...v1.14.0)

---
updated-dependencies:
- dependency-name: Terminal.Gui
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [NLog](https://github.com/NLog/NLog) from 5.2.3 to 5.2.4.
- [Release notes](https://github.com/NLog/NLog/releases)
- [Changelog](https://github.com/NLog/NLog/blob/dev/CHANGELOG.md)
- [Commits](NLog/NLog@v5.2.3...v5.2.4)

---
updated-dependencies:
- dependency-name: NLog
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [Scintilla.NET](https://github.com/VPKSoft/ScintillaNET) from 5.3.2.7 to 5.3.2.9.
- [Release notes](https://github.com/VPKSoft/ScintillaNET/releases)
- [Commits](desjarlais/Scintilla.NET@v.5.3.2.7...v.5.3.2.9)

---
updated-dependencies:
- dependency-name: Scintilla.NET
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [crazy-max/ghaction-chocolatey](https://github.com/crazy-max/ghaction-chocolatey) from 2 to 3.
- [Release notes](https://github.com/crazy-max/ghaction-chocolatey/releases)
- [Commits](crazy-max/ghaction-chocolatey@v2...v3)

---
updated-dependencies:
- dependency-name: crazy-max/ghaction-chocolatey
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [SixLabors.ImageSharp.Drawing](https://github.com/SixLabors/ImageSharp.Drawing) from 1.0.0 to 2.0.0.
- [Release notes](https://github.com/SixLabors/ImageSharp.Drawing/releases)
- [Commits](SixLabors/ImageSharp.Drawing@v1.0.0...v2.0.0)

---
updated-dependencies:
- dependency-name: SixLabors.ImageSharp.Drawing
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps NSubstitute from 5.0.0 to 5.1.0.

---
updated-dependencies:
- dependency-name: NSubstitute
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v3...v4)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@JFriel JFriel changed the base branch from develop to feature/rc4 September 18, 2023 10:46
@JFriel JFriel closed this Sep 19, 2023
@JFriel JFriel deleted the task/fix-up-rc4 branch November 6, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants