Make file locator handle Unix and DOS style paths more smartly #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkm
approved these changes
Feb 10, 2023
| @@ -18,32 +18,46 @@ internal class MdfFileAttachLocations | |||
| { | |||
| public MdfFileAttachLocations(DirectoryInfo originDirectory, string databaseDirectoryFromPerspectiveOfDatabaseServer, string copyToDirectoryOrNullIfDatabaseIsLocalhost) | |||
| { | |||
| if (databaseDirectoryFromPerspectiveOfDatabaseServer == null) | |||
| throw new ArgumentNullException("databaseDirectoryFromPerspectiveOfDatabaseServer"); | |||
| ArgumentNullException.ThrowIfNull(databaseDirectoryFromPerspectiveOfDatabaseServer); | |||
rkm
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish previous fix - autodetect whether to use Unix or DOS style paths and adjust separator accordingly. Can't rely on Path.Combine - that gets it right for the local machine, not the remote one!