Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/mysqltext #212

Merged
merged 4 commits into from
Aug 16, 2023
Merged

Bugfix/mysqltext #212

merged 4 commits into from
Aug 16, 2023

Conversation

jas88
Copy link
Member

@jas88 jas88 commented Aug 14, 2023

MySQL translation incorrectly uses TEXT type columns (64k limit) instead of LONGTEXT. Fixed in this PR, along with a typo and incorrect column length limit values for tinytext/text/mediumtext/longtext types.

Also cleans some whitespace, so best reviewed filtering that out: https://github.com/HicServices/FAnsiSql/pull/212/files?diff=unified&w=1

@jas88 jas88 requested a review from JFriel August 15, 2023 14:13
Copy link
Contributor

@JFriel JFriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all LGTM. Does this change need column type migrations on existing installations?

@jas88
Copy link
Member Author

jas88 commented Aug 16, 2023

@JFriel Theoretically yes - fortunately in this case the only installation affected is HIC's own PODMAN, where logging is space constrained anyway, so not an issue.

@jas88 jas88 merged commit 7107c7b into main Aug 16, 2023
@jas88 jas88 deleted the bugfix/mysqltext branch August 16, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants