-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RIS-1225] Move to Ruby 3.0.x #52
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# top-most EditorConfig file | ||
root = true | ||
|
||
# Unix-style newlines with a newline ending every file | ||
# Indent with 2 spaces | ||
[*] | ||
end_of_line = lf | ||
insert_final_newline = true | ||
indent_style = space | ||
indent_size = 2 | ||
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
AllCops: | ||
TargetRubyVersion: 2.7 | ||
TargetRubyVersion: 3.0 | ||
|
||
Metrics/ClassLength: | ||
Enabled: false | ||
|
@@ -103,3 +103,6 @@ Security/YAMLLoad: | |
|
||
Style/RegexpLiteral: | ||
Enabled: false | ||
|
||
Naming/VariableNumber: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Disabling this rule as it appears to apply to keys returned from the bambora API. |
||
Enabled: false |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
2.7.7 | ||
3.0.5 |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,7 +37,7 @@ Gem::Specification.new do |spec| | |
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } | ||
spec.require_paths = ['lib'] | ||
|
||
spec.required_ruby_version = '>= 2.7.7' | ||
spec.required_ruby_version = '>= 3.0.5' | ||
|
||
spec.add_dependency 'faraday', '~> 2.0.1' | ||
spec.add_dependency 'faraday-excon' | ||
|
@@ -46,11 +46,11 @@ Gem::Specification.new do |spec| | |
spec.add_dependency 'multiparty', '~> 0' | ||
|
||
spec.add_development_dependency 'bundler', '~> 2' | ||
spec.add_development_dependency 'pry', '~> 0.12.0' | ||
spec.add_development_dependency 'pry-byebug', '~> 3.7' | ||
spec.add_development_dependency 'pry' | ||
spec.add_development_dependency 'pry-byebug' | ||
spec.add_development_dependency 'rake', '~> 13.0' | ||
spec.add_development_dependency 'rspec', '~> 3.0' | ||
spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1' | ||
spec.add_development_dependency 'rubocop', '~> 0.74.0' | ||
spec.add_development_dependency 'rubocop', '~> 1.12.0' | ||
Comment on lines
+49
to
+54
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Minimum version bumps required to successfully run under Ruby 3.0 |
||
spec.add_development_dependency 'webmock', '~> 3.7' | ||
end |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ def to_h | |
parsed_response = super | ||
return error_response if parsed_response.values.flatten.empty? # We didn't get a query string back. | ||
|
||
parsed_response.each_with_object({}) { |(key, val), obj| obj[key] = val.length == 1 ? val.first : val } | ||
parsed_response.transform_values { |val| val.length == 1 ? val.first : val } | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Linting changes from the Rubocop change moving us to 3.0 compatibility. These were all from their "auto-correct" package. |
||
end | ||
|
||
private | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,6 +2,6 @@ | |
|
||
module Bambora | ||
class Client | ||
VERSION = '0.6.0' | ||
VERSION = '0.7.0' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Version bump. Last time I forgot to create a |
||
end | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Being a good citizen 🖖