fix: file path normalization on Windows #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiDeoo
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
Thanks for the report and the pull request, super appreciated 🙌
The changes to the integration workflow makes total sense, I just increased the test timeout as this seems to take a bit longer on a Windows vm and fix Prettier complaining about Windows line endings.
github-merge-queue bot
referenced
this pull request
in knope-dev/knope
Nov 6, 2023
) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [starlight-links-validator](https://togithub.com/HiDeoo/starlight-links-validator) | [`0.4.1` -> `0.4.2`](https://renovatebot.com/diffs/npm/starlight-links-validator/0.4.1/0.4.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>HiDeoo/starlight-links-validator (starlight-links-validator)</summary> ### [`v0.4.2`](https://togithub.com/HiDeoo/starlight-links-validator/releases/tag/v0.4.2) [Compare Source](https://togithub.com/HiDeoo/starlight-links-validator/compare/v0.4.1...v0.4.2) ##### 🐞 Bug Fixes - File path normalization on Windows - by [@​Genteure](https://togithub.com/Genteure) and [@​HiDeoo](https://togithub.com/HiDeoo) in [https://github.com/HiDeoo/starlight-links-validator/issues/15](https://togithub.com/HiDeoo/starlight-links-validator/issues/15) [<samp>(ba1be)</samp>](https://togithub.com/HiDeoo/starlight-links-validator/commit/ba1be29) - Validate reference-style links - by [@​HiDeoo](https://togithub.com/HiDeoo) [<samp>(9a9f2)</samp>](https://togithub.com/HiDeoo/starlight-links-validator/commit/9a9f2fb) ##### [View changes on GitHub](https://togithub.com/HiDeoo/starlight-links-validator/compare/v0.4.1...v0.4.2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/knope-dev/knope). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40Ni4wIiwidXBkYXRlZEluVmVyIjoiMzcuNDYuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Fix file path normalization on Windows.
Added
windows-latestto the Lint & Test workflow to test on Windows.strategy.fail-fastis set tofalsebecause currently the run time is pretty short (less than 2 minutes), and when some tests are failing on one OS it's helpful to know whether they are failing on the other OS too.Test is moved before Lint to have a faster feedback loop for functionality regardless if the code is formatted correctly.
Fix #13
Why
link validation was not working on Windows.
How
Instead of only splitting the path by
/, it now split paths by/or\.Screenshots
N/A