Plasma in-situ diags #968
Merged
Plasma in-situ diags #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeverinDiederichs
added
component: plasma
SeverinDiederichs
requested review from
AlexanderSinn and
MaxThevenet
and removed request for
AlexanderSinn
9 tasks
MaxThevenet
requested changes
Jun 5, 2023
tools/read_insitu_diagnostics.py
Outdated
Comment on lines
100
to
135
| def temperature_in_ev_x(all_data, per_slice=True): | ||
| if per_slice: | ||
| if all_data["is_normalized_units"][0]: | ||
| return (constants.m_e * constants.c**2 / constants.e) * normalized_momentum_std_x(all_data)**2 * np.atleast_2d(all_data["mass"]).T | ||
| else: | ||
| return (constants.c**2 / constants.e) * normalized_momentum_std_x(all_data)**2 * np.atleast_2d(all_data["mass"]).T | ||
| else: | ||
| if all_data["is_normalized_units"][0]: | ||
| return (constants.m_e * constants.c**2 / constants.e) * normalized_momentum_std_x(all_data["average"])**2 * all_data["mass"] | ||
| else: | ||
| return (constants.c**2 / constants.e) * normalized_momentum_std_x(all_data["average"])**2 * all_data["mass"] | ||
|
|
||
| def temperature_in_ev_y(all_data, per_slice=True): | ||
| if per_slice: | ||
| if all_data["is_normalized_units"][0]: | ||
| return (constants.m_e * constants.c**2 / constants.e) * normalized_momentum_std_y(all_data)**2 * np.atleast_2d(all_data["mass"]).T | ||
| else: | ||
| return (constants.c**2 / constants.e) * normalized_momentum_std_y(all_data)**2 * np.atleast_2d(all_data["mass"]).T | ||
| else: | ||
| if all_data["is_normalized_units"][0]: | ||
| return (constants.m_e * constants.c**2 / constants.e) * normalized_momentum_std_y(all_data["average"])**2 * all_data["mass"] | ||
| else: | ||
| return (constants.c**2 / constants.e) * normalized_momentum_std_y(all_data["average"])**2 * all_data["mass"] | ||
|
|
||
| def temperature_in_ev_z(all_data, per_slice=True): | ||
| if per_slice: | ||
| if all_data["is_normalized_units"][0]: | ||
| return (constants.m_e * constants.c**2 / constants.e) * normalized_momentum_std_z(all_data)**2 * np.atleast_2d(all_data["mass"]).T | ||
| else: | ||
| return (constants.c**2 / constants.e) * normalized_momentum_std_z(all_data)**2 * np.atleast_2d(all_data["mass"]).T | ||
| else: | ||
| if all_data["is_normalized_units"][0]: | ||
| return (constants.m_e * constants.c**2 / constants.e) * normalized_momentum_std_z(all_data["average"])**2 * all_data["mass"] | ||
| else: | ||
| return (constants.c**2 / constants.e) * normalized_momentum_std_z(all_data["average"])**2 * all_data["mass"] | ||
|
|
There was a problem hiding this comment.
Could you merge these 3 with a new mandatory input parameter? Maybe define a function normalized_momentum_std that is a copy of _x or _y etc. depending on the direction, and then have the cumbersome piece of code only once?
There was a problem hiding this comment.
Tried to clean it, please have a look (best use split screen, otherwise it is awful to look at)
Co-authored-by: Maxence Thévenet <[email protected]>
Comment on lines
+559
to
+562
| #ifdef HIPACE_USE_OPENPMD | ||
| // create subdirectory | ||
| openPMD::auxiliary::create_directories(m_insitu_file_prefix); | ||
| #endif |
There was a problem hiding this comment.
Here we need openPMD::auxiliary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds plasma in-situ diagnostics. They can be used to calculate e.g., the temperature evolution of the plasma.
I also refactored the documentation on in-situ diagnostics a little bit.
constisconst)