-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to symmetrize plasma #943
Merged
AlexanderSinn
merged 9 commits into
Hi-PACE:development
from
SeverinDiederichs:symmetrize_plasma2
May 10, 2023
Merged
Option to symmetrize plasma #943
AlexanderSinn
merged 9 commits into
Hi-PACE:development
from
SeverinDiederichs:symmetrize_plasma2
May 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
correction Co-authored-by: AlexanderSinn <[email protected]>
AlexanderSinn
approved these changes
May 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #891 (there was an index missing)
This PR proposes to symmetrize the plasma at initialization. This prevents the numerical seeding of the hosing instability for a finite temperature.
The symmetrization increases the level of noise due to the temperature in comparison to using the same amount of random particles (symmetrization increases the number of particles by 4). As shown below. As one can see, the noise is quite symmetric in x (see e.g., at the axis at -1 or -2.). Note that one could also symmetrize the plasma in z.
The symmetrization from this PR is sufficient to prevent the hosing instability to be seeded from the numerical noise of the temperature:
const
isconst
)