Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to symmetrize plasma #943

Merged

Conversation

SeverinDiederichs
Copy link
Member

@SeverinDiederichs SeverinDiederichs commented May 9, 2023

Update of #891 (there was an index missing)

This PR proposes to symmetrize the plasma at initialization. This prevents the numerical seeding of the hosing instability for a finite temperature.

The symmetrization increases the level of noise due to the temperature in comparison to using the same amount of random particles (symmetrization increases the number of particles by 4). As shown below. As one can see, the noise is quite symmetric in x (see e.g., at the axis at -1 or -2.). Note that one could also symmetrize the plasma in z.
Untitled

The symmetrization from this PR is sufficient to prevent the hosing instability to be seeded from the numerical noise of the temperature:
temperature_instability

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@SeverinDiederichs SeverinDiederichs added the component: plasma About the plasma species label May 9, 2023
Copy link
Member

@AlexanderSinn AlexanderSinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexanderSinn AlexanderSinn merged commit 7d7edd9 into Hi-PACE:development May 10, 2023
@SeverinDiederichs SeverinDiederichs deleted the symmetrize_plasma2 branch May 10, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: plasma About the plasma species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants