Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checksum: Back to openPMD-viewer default #729

Merged
merged 1 commit into from
Apr 15, 2022

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Apr 15, 2022

Switch back to openPMD-viewer default backend of openPMD-api, since openPMD-viewer 1.4.0 fixed the performance regression introduced in 1.3.0:
https://github.com/openPMD/openPMD-viewer/releases/tag/1.4.0

Follow-up to #725

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

Switch back to openPMD-viewer default backend of openPMD-api,
since openPMD-viewer 1.4.0 fixed the performance regression
introduced in 1.3.0:
https://github.com/openPMD/openPMD-viewer/releases/tag/1.4.0
@ax3l ax3l requested a review from AlexanderSinn April 15, 2022 00:13
@ax3l ax3l added the CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. label Apr 15, 2022
@ax3l
Copy link
Member Author

ax3l commented Apr 15, 2022

Run ctest --test-dir build --output-on-failure
Internal ctest changing into directory: /home/runner/work/hipace/hipace/build
Test project /home/runner/work/hipace/hipace/build
      Start  1: blowout_wake.2Rank
 1/25 Test  #1: blowout_wake.2Rank ..............................   Passed    9.00 sec
      Start  2: collisions.SI.1Rank
 2/25 Test  #2: collisions.SI.1Rank .............................   Passed    1.59 sec
      Start  3: ionization.2Rank
 3/25 Test  #3: ionization.2Rank ................................   Passed    2.94 sec
      Start  4: from_file.normalized.1Rank
 4/25 Test  #4: from_file.normalized.1Rank ......................   Passed    3.38 sec
      Start  5: from_file.SI.1Rank
 5/25 Test  #5: from_file.SI.1Rank ..............................   Passed    3.32 sec
      Start  6: restart.normalized.1Rank
 6/25 Test  #6: restart.normalized.1Rank ........................   Passed    1.33 sec
      Start  7: blowout_wake_explicit.2Rank
 7/25 Test  #7: blowout_wake_explicit.2Rank .....................   Passed    2.42 sec
      Start  8: laser_blowout_wake_explicit.1Rank
 8/25 Test  #8: laser_blowout_wake_explicit.1Rank ...............   Passed    4.89 sec
      Start  9: laser_blowout_wake_explicit.SI.1Rank
 9/25 Test  #9: laser_blowout_wake_explicit.SI.1Rank ............   Passed    5.05 sec
      Start 10: beam_evolution.1Rank
10/25 Test #10: beam_evolution.1Rank ............................   Passed    2.86 sec
      Start 11: adaptive_time_step.1Rank
11/25 Test #11: adaptive_time_step.1Rank ........................   Passed    6.98 sec
      Start 12: grid_current.1Rank
12/25 Test #12: grid_current.1Rank ..............................   Passed    1.55 sec
      Start 13: linear_wake.normalized.1Rank
13/25 Test #13: linear_wake.normalized.1Rank ....................   Passed    3.77 sec
      Start 14: linear_wake.SI.1Rank
14/25 Test #14: linear_wake.SI.1Rank ............................   Passed    3.75 sec
      Start 15: gaussian_linear_wake.normalized.1Rank
15/25 Test #15: gaussian_linear_wake.normalized.1Rank ...........   Passed    3.26 sec
      Start 16: gaussian_linear_wake.SI.1Rank
16/25 Test #16: gaussian_linear_wake.SI.1Rank ...................   Passed    3.20 sec
      Start 17: reset.2Rank
17/25 Test #17: reset.2Rank .....................................   Passed    2.68 sec
      Start 18: beam_in_vacuum.SI.1Rank
18/25 Test #18: beam_in_vacuum.SI.1Rank .........................   Passed    7.24 sec
      Start 19: beam_in_vacuum.normalized.1Rank
19/25 Test #19: beam_in_vacuum.normalized.1Rank .................   Passed    6.45 sec
      Start 20: next_deposition_beam.2Rank
20/25 Test #20: next_deposition_beam.2Rank ......................   Passed   12.91 sec
      Start 21: slice_IO.1Rank
21/25 Test #21: slice_IO.1Rank ..................................   Passed   11.46 sec
      Start 22: output_coarsening.2Rank
22/25 Test #22: output_coarsening.2Rank .........................   Passed   15.08 sec
      Start 23: gaussian_weight.1Rank
23/25 Test #23: gaussian_weight.1Rank ...........................   Passed    4.59 sec
      Start 24: beam_in_vacuum.normalized.2Rank
24/25 Test #24: beam_in_vacuum.normalized.2Rank .................   Passed   13.95 sec
      Start 25: beam_in_vacuum_open_boundary.normalized.1Rank
25/25 Test #25: beam_in_vacuum_open_boundary.normalized.1Rank ...   Passed    7.67 sec

100% tests passed, 0 tests failed out of 25

Total Test time (real) = 141.37 sec

🎉

@ax3l
Copy link
Member Author

ax3l commented Apr 15, 2022

Collecting pip
  Downloading pip-22.0.4-py3-none-any.whl (2.1 MB)
Installing collected packages: pip
Successfully installed pip-22.0.4
Defaulting to user installation because normal site-packages is not writeable
Collecting matplotlib==3.2.2
  Downloading matplotlib-3.2.2-cp38-cp38-manylinux1_x86_64.whl (12.4 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 12.4/12.4 MB 80.9 MB/s eta 0:00:00
Collecting numpy
  Downloading numpy-1.22.3-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (16.8 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 16.8/16.8 MB 69.4 MB/s eta 0:00:00
Collecting scipy
  Downloading scipy-1.8.0-cp38-cp38-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (41.6 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 41.6/41.6 MB 29.4 MB/s eta 0:00:00
Collecting openpmd-viewer
  Downloading openPMD_viewer-1.4.0-py3-none-any.whl (85 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 85.7/85.7 KB 7.9 MB/s eta 0:00:00
Collecting openpmd-api
  Downloading openPMD_api-0.14.4-cp38-cp38-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (6.9 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 6.9/6.9 MB 86.3 MB/s eta 0:00:00
Collecting python-dateutil>=2.1
  Downloading python_dateutil-2.8.2-py2.py3-none-any.whl (247 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 247.7/247.7 KB 56.7 MB/s eta 0:00:00
Requirement already satisfied: pyparsing!=2.0.4,!=2.1.2,!=2.1.6,>=2.0.1 in /usr/local/lib/python3.8/dist-packages (from matplotlib==3.2.2) (3.0.8)
Collecting cycler>=0.10
  Downloading cycler-0.11.0-py3-none-any.whl (6.4 kB)
Collecting kiwisolver>=1.0.1
  Downloading kiwisolver-1.4.2-cp38-cp38-manylinux_2_5_x86_64.manylinux1_x86_64.whl (1.2 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 1.2/1.2 MB 79.5 MB/s eta 0:00:00
Collecting tqdm
  Downloading tqdm-4.64.0-py2.py3-none-any.whl (78 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 78.4/78.4 KB 20.8 MB/s eta 0:00:00
Collecting h5py>=2.8.0
  Downloading h5py-3.6.0-cp38-cp38-manylinux_2_12_x86_64.manylinux2010_x86_64.whl (4.5 MB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 4.5/4.5 MB 90.6 MB/s eta 0:00:00
Requirement already satisfied: six>=1.5 in /usr/lib/python3/dist-packages (from python-dateutil>=2.1->matplotlib==3.2.2) (1.14.0)
Installing collected packages: tqdm, python-dateutil, numpy, kiwisolver, cycler, scipy, openpmd-api, matplotlib, h5py, openpmd-viewer
Successfully installed cycler-0.11.0 h5py-3.6.0 kiwisolver-1.4.2 matplotlib-3.2.2 numpy-1.22.3 openpmd-api-0.14.4 openpmd-viewer-1.4.0 python-dateutil-2.8.2 scipy-1.8.0 tqdm-4.64.0

Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks!

@MaxThevenet MaxThevenet merged commit 3b73f2c into Hi-PACE:development Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration, checksum and analysis tests, GitHub Actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants