Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laser ionization #1190

Merged
merged 83 commits into from
Jan 17, 2025
Merged

Laser ionization #1190

merged 83 commits into from
Jan 17, 2025

Conversation

EyaDammak
Copy link
Contributor

@EyaDammak EyaDammak commented Dec 13, 2024

This pull request introduces a new implementation for ionization by a linear or circularly polarized laser.

It adds a new test called "laser_ionization", which benchmarks the ionization fraction produced by a plane wave laser against the WarpX simulation results for a specific a0 value.
Checksum test only available on CPU and for linear case.

Note that this implementation currently ignores the momentum of the ionized electrons (momentum is set to 0).

@EyaDammak EyaDammak changed the title [WIP] Laser ionisation [WIP] Laser ionization Dec 13, 2024
@EyaDammak EyaDammak changed the title [WIP] Laser ionization Laser ionization Dec 20, 2024
@EyaDammak
Copy link
Contributor Author

This PR is likely ready to be merged now
Style reviewed again, comments added, reviews solved except the verification that the checksum is only executed on the CPU

Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, see additional points below.

examples/laser_ionization/analysis_laser_ionization.py Outdated Show resolved Hide resolved
examples/laser_ionization/analysis_laser_ionization.py Outdated Show resolved Hide resolved
examples/laser_ionization/analysis_laser_ionization.py Outdated Show resolved Hide resolved
examples/laser_ionization/analysis_laser_ionization.py Outdated Show resolved Hide resolved
examples/laser_ionization/analysis_laser_ionization.py Outdated Show resolved Hide resolved
src/particles/plasma/PlasmaParticleContainer.cpp Outdated Show resolved Hide resolved
src/particles/plasma/PlasmaParticleContainer.cpp Outdated Show resolved Hide resolved
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MaxThevenet MaxThevenet merged commit 29c2a53 into Hi-PACE:development Jan 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants