Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable initial pulse front tilt set for lasers #1100

Merged
merged 21 commits into from
May 2, 2024

Conversation

huixingjian
Copy link
Contributor

@huixingjian huixingjian commented Apr 18, 2024

The lasers could have initial pulse front tilt angle on yoz plane by <laser name>.PFT_yz —the angle between the pulse front (maximum intensity contour)and the propagation direction defined by [Selcuk Akturk Opt. Express 12 (2004)]
Screenshot 2024-04-19 at 14 23 36

@huixingjian huixingjian changed the title Enable initial pulse front tilt set for lasers [WIP]Enable initial pulse front tilt set for lasers Apr 18, 2024
@huixingjian huixingjian changed the title [WIP]Enable initial pulse front tilt set for lasers Enable initial pulse front tilt set for lasers Apr 19, 2024
@@ -25,9 +26,11 @@ public:
amrex::Real m_CEP {0.}; /**< Laser carrier-envelope phase (CEP) */
/** Propagation angle of the pulse in the yz plane (0 is the along the z axis) */
amrex::Real m_propagation_angle_yz {0.};
/**Pulse front tilt angle of the pulse in yz plane (pi/2 is no PFT)*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/**Pulse front tilt angle of the pulse in yz plane (pi/2 is no PFT)*/
/**Pulse front tilt angle of the pulse in yz plane (pi/2 is no PFT)*/

Can you add 4 spaces in front of the comments so it lines up with the other stuff.

amrex::Real m_L0 {0.}; /**< Laser length (HW 1/e in amplitude) */
amrex::Real m_tau {0.}; /**< Laser duration (HW 1/e in amplitude) */
/** Focal distance of the laser pulse */
/** Focal distance of the laser pulse */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Focal distance of the laser pulse */
/** Focal distance of the laser pulse */

Copy link
Member

@AlexanderSinn AlexanderSinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@AlexanderSinn AlexanderSinn merged commit 99b0ab8 into Hi-PACE:development May 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants