Simplify tiling in plasma deposition #1093
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the temp density arrays that were used for the plasma current deposition were removed. Instead, thread safety is ensured by splitting the tiles into four groups such that tiles within a group don’t overlap. Shown below is the chi array after the first group of tiles was deposited. This cleans up the code, as the temp densities don’t have to be allocated and managed anymore, and gives a small performance improvement because the lockAdd to the main array is not necessary anymore.
Performance for a
2047*2047*300
grid, exactly one tile per thread on dual 48 core CPUs:const
isconst
)