Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Maxwell documentation to setup and run #1076

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

MaxThevenet
Copy link
Member

Issues reported by a user, suggestions/improvements welcome.

@MaxThevenet MaxThevenet added documentation Improvements or additions to documentation build CMake, compilation, etc. labels Feb 29, 2024
HiPACE++:

.. code-block:: bash

#!/usr/bin/env zsh # Shell is assumed to be zsh
Copy link
Member

@AlexanderSinn AlexanderSinn Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you need here also?

module ()
{
eval `modulecmd bash $*`
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the proper configuration (maybe just the Shebang, but I am not sure what else is important here), we do not need this anymore. So I'd be in favor of not adding the module thingy in the documentation at the moment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I source profile.hipace directly from the console it is not necessary, but if the source is in another script that is executed in a new shell (e.g. bash script.sh or ./script.sh) then it is needed.

Copy link
Member Author

@MaxThevenet MaxThevenet Mar 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I added this as a tip

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexanderSinn AlexanderSinn merged commit 068f3b6 into Hi-PACE:development Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CMake, compilation, etc. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants