Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS CI explicitly install [email protected] #1049

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Dec 17, 2023

There seems to be a particular MacOS CI runner environment where python 3.11 is installed with brew and 3.12 using something else, so when brew later installs python 3.12 as a dependency of openpmd-api it fails to create the links for 3.12.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the CI Continuous integration, checksum and analysis tests, GitHub Actions, etc. label Dec 17, 2023
@AlexanderSinn AlexanderSinn changed the title MacOS CI add --overwrite to brew install MacOS CI explicitly install [email protected] Dec 17, 2023
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for this PR, ping @ax3l who wrote this part.

@AlexanderSinn
Copy link
Member Author

I need to merge this to fix the CI of other PRs

@AlexanderSinn AlexanderSinn merged commit 8eea8bb into Hi-PACE:development Dec 19, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous integration, checksum and analysis tests, GitHub Actions, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants