Fix problem caused by #248 and #249 #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, great fix! No worries, i have not even released it in stable branch yet. This is what we do in the dev branch 👍😀 |
|
You need to rebase this onto hexagon/dev to remove the old commits the pr. If your unsure how to do it you can just check "Allow edits from maintainers" in this pr 👍 |
…1st occurrence because of increment
|
How is this? |
|
Looking great 💯 Will release as |
|
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While all the tests passed in the last 2 PRs, I did not check if the jobs were actually running. If the
startAtis in the past, it will increment to the next time, and if it is in the future, then it will add one minute for some reason.Given the combination of these 2 factors, it caused the 1st run of an interval set in the future not to occur.
The solution to this was to just add a check that if the
startAtandintervalare set, then don't increment thenextRunby one minute because thestartAtis already the first time it should run.@Hexagon, I sincerely apologize that I had to send 3 PRs just to clear up one issue, but this time I have done all my testing with Uptime Kuma and all other tests I could think of and it passes everything.
I am confidant this has fixed the issue now, I again apologize for the trouble that I caused.