重构编译工作流文件 #4009
Merged
重构编译工作流文件 #4009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3gf8jv4dv
suggested changes
Jun 12, 2024
|
你也没必要把人家的注释都删了吧…… |
|
下次在有相同主题的PR还Open的时候，建议优先给那个PR的分支发PR，这样不用处理冲突…… |
你说得不对，因为那样直接合并的话你的成果就废了。 |
这是重构，只不过文件名和部分代码重复了而已（ |
3gf8jv4dv
suggested changes
Jun 12, 2024
3gf8jv4dv
reviewed
Jun 12, 2024
|
@3gf8jv4dv How about looking at the file name now? |
Now this looks great! By the way, I have seen the format you wrote in other projects, but I just remembered it when I saw it just now, lol. |
3gf8jv4dv
approved these changes
Jun 12, 2024
Git的文本引擎可以按行合并，而且您可以从分支的仓库拉取进行修改，这样就不会出现上述情况。 |
没啥用。 |
|
把已有的注释给删了并没有让东西变得更好，并且也是对其他人的不尊重。不要这样做。 |
|
我没删我直接给重构的……你不信你去看 Commit 历史。 |
|
唉，行吧…… |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
我个人认为并没有必要要多一个友好名称……
增加上传文件名带
版本 tag-Commit 次数-g + 提交 Short Hash，然后……先等等吧，看看有没啥好的意见，可以去#3987 或下方 Comment，我觉得能做的话会加进#3987 里面，然后把此 PR 标记为 Draft。