Add debug logging option #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AislingHPE
force-pushed
the
debug-logging
branch
5 times, most recently
from
6d1dab4 to
addf9af
Compare
And fix stdout so nothing except the schema prints (unless there is an error).
Also add debug logging for the reader package, and for validation rules.
```
Debug: found the following files in "/home/aisling/dev/HewlettPackard/terraschema/test/modules/simple":
"/home/aisling/dev/HewlettPackard/terraschema/test/modules/simple/main.tf", with variable(s):
"/home/aisling/dev/HewlettPackard/terraschema/test/modules/simple/variables.tf", with variable(s):
name
age
Warning: couldn't apply validation for "age" with condition "var.age > env.age": no translation rules are supported for this condition
Debug: condition located at "/home/aisling/dev/HewlettPackard/terraschema/test/modules/simple/variables.tf:14,21-38"
Debug: the following errors occurred:
contains([...],var.input_parameter): condition is not a 'contains()' function
var == "a" || var == "b": operator is not || or ==
a <>= (variable or variable length) (&& ...): could not evaluate expression as a constant value: /home/aisling/dev/HewlettPackard/terraschema/test/modules/simple/variables.tf:14,31-34: Variables not allowed; Variables may not be used here.
can(regex("...",var.input_parameter)): rule can only be applied to string types, not "number"
Schema written to "/home/aisling/dev/HewlettPackard/terraschema/schema.json"
```
AislingHPE
force-pushed
the
debug-logging
branch
from
addf9af to
bdb8ea0
Compare
stuart-mclaren-hpe
approved these changes
Aug 27, 2024
| "unless an error occurs. Overrides 'debug' and 'output.", | ||
| ) | ||
|
|
||
| rootCmd.Flags().BoolVar(&debugOut, "debug", false, | ||
| "output debug logs, may useful for troubleshooting issues relating to translating\n"+ | ||
| "validation rules. Does not work with --stdout", |
There was a problem hiding this comment.
Could send to stderr. But I suspect you're not up for that :-)
| @@ -92,8 +86,21 @@ func createNode(name string, v model.TranslatedVariable, options CreateSchemaOpt | |||
| if v.Variable.Validation != nil && v.ConditionAsString != nil { | |||
| err = parseConditionToNode(v.Variable.Validation.Condition, *v.ConditionAsString, name, &node) | |||
| // if an error occurs, log it and continue. | |||
| if err != nil { | |||
| fmt.Printf("couldn't apply validation for %q with condition %q. Error: %v\n", name, *v.ConditionAsString, err) | |||
| if err != nil && !options.SuppressLogging { | |||
There was a problem hiding this comment.
Having logging configuration affect control flow will work, but there may be a neater way to do the same thing.
There was a problem hiding this comment.
Probably, but slog gives me a headache and this does the job for now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix stdout so nothing except the schema prints (unless there is an error).
Also add debug logging for the reader package, and for validation rules.