Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added san storage attribute #320

Merged
merged 9 commits into from
Jun 8, 2021
Merged

Added san storage attribute #320

merged 9 commits into from
Jun 8, 2021

Conversation

nabhajit-ray
Copy link
Collaborator

Description

[Added san storage attribute]

Issues Resolved

[List any issues this PR will resolve. e.g., Fixes #1]

Check List

  • New functionality includes testing.
    • All tests pass for go 1.11 + gofmt checks.
  • New functionality has been documented in the README if applicable.
    • New functionality has been thoroughly documented in the examples (please include helpful comments).
    • New endpoints supported are updated in the endpoints-support.md file.
  • Changes are documented in the CHANGELOG.

}
}
serverProfile.SanStorage = sanStorage
}
if _, ok := d.GetOk("volume_attachments"); ok {
rawVolumeAttachments := d.Get("volume_attachments").(*schema.Set).List()
rawVolumeAttachments := d.Get("volume_attachments").([]interface{})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the difference b/w interface and schema.Set

Copy link
Collaborator Author

@nabhajit-ray nabhajit-ray Jun 8, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the type from typeset to typelist so the conversion is added

Copy link
Collaborator

@AsisBagga AsisBagga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Update docs.

@nabhajit-ray
Copy link
Collaborator Author

Please Update docs.

Done

Copy link
Collaborator

@AsisBagga AsisBagga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabhajit-ray nabhajit-ray merged commit 6d5130f into master Jun 8, 2021
@nabhajit-ray nabhajit-ray deleted the SanStorage_OV6.2 branch July 12, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants