-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added san storage attribute #320
Conversation
} | ||
} | ||
serverProfile.SanStorage = sanStorage | ||
} | ||
if _, ok := d.GetOk("volume_attachments"); ok { | ||
rawVolumeAttachments := d.Get("volume_attachments").(*schema.Set).List() | ||
rawVolumeAttachments := d.Get("volume_attachments").([]interface{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the difference b/w interface
and schema.Set
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the type from typeset to typelist so the conversion is added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please Update docs.
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
[Added san storage attribute]
Issues Resolved
[List any issues this PR will resolve. e.g., Fixes #1]
Check List