Api deprecation changes #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 5, 2020
oneview/config.go
Outdated
| c.OVAPIVersion = apiver.CurrentVersion | ||
| } else if c.OVAPIVersion < apiver.MinimumVersion { | ||
| //Throw error if provided api version is not supported | ||
| return errors.New(fmt.Sprintf("The minimum api version supported is %d", apiver.MinimumVersion)) |
There was a problem hiding this comment.
should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...)
houndci-bot
reviewed
Sep 7, 2020
oneview/config.go
Outdated
| //If no api version is provided use the current version to create client | ||
| if c.OVAPIVersion == 0 { | ||
| if err != nil { | ||
| return errors.New(fmt.Sprintf("Could not fetch the appliance %s api version", c.OVEndpoint)) |
There was a problem hiding this comment.
should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...)
nabhajit-ray
requested review from
AsisBagga,
chebroluharika,
VenkateshRavula and
yuvirani
| @@ -53,7 +53,7 @@ func Provider() terraform.ResourceProvider { | |||
| "ov_apiversion": { | |||
| Type: schema.TypeInt, | |||
| Optional: true, | |||
| DefaultFunc: schema.EnvDefaultFunc("ONEVIEW_OV_API_VERSION", 200), | |||
| DefaultFunc: schema.EnvDefaultFunc("ONEVIEW_OV_API_VERSION", 0), | |||
There was a problem hiding this comment.
what does this mean..?
There was a problem hiding this comment.
Default api version in the schema if the value is not found. Keeping it 0, we are controlling what to for set the api version
VenkateshRavula
approved these changes
Sep 8, 2020
yuvirani
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Api deprecation changes]
Issues Resolved
[]
Check List