add permission on operation #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove "version" flag
EliasBoulharts
approved these changes
Dec 13, 2024
a-belhadj
reviewed
Dec 13, 2024
| @@ -1,6 +1,4 @@ | |||
| # add this file to the docker compose execution when developing Squest | |||
| version: '3.7' | |||
|
|
|||
| services: | |||
There was a problem hiding this comment.
CHANGELOG Breaking changes does not support docker compose v1 anymore
a-belhadj
reviewed
Dec 13, 2024
| ContentType = apps.get_model('contenttypes', 'ContentType') | ||
| operation_content_type = ContentType.objects.get_for_model(Operation) | ||
|
|
||
| is_admin_operation, _ = Permission.objects.get_or_create(codename="is_admin_operation", content_type=operation_content_type) |
There was a problem hiding this comment.
view_admin_operation to stay consistent
a-belhadj
reviewed
Dec 13, 2024
| @@ -116,6 +115,8 @@ def __str__(self): | |||
| @property | |||
| def docs(self): | |||
| filtered_doc = list() | |||
| if self.service is None: | |||
There was a problem hiding this comment.
service shouldn't be None, it should be required in Instance
a-belhadj
reviewed
Dec 13, 2024
service_catalog/views/instance.py
Outdated
| @@ -1,4 +1,5 @@ | |||
| import logging | |||
| from gc import enable | |||
a-belhadj
reviewed
Dec 13, 2024
Comment on lines
+15
to
+25
| "permission": FormUtils.get_default_permission_for_operation(), | ||
| }, | ||
| { | ||
| "name": "new_service_2", | ||
| "description": "a new service 2", | ||
| "permission": FormUtils.get_default_permission_for_operation(), | ||
| }, | ||
| { | ||
| "name": "new_service_3", | ||
| "description": "a new service 3" | ||
| "description": "a new service 3", | ||
| "permission": FormUtils.get_default_permission_for_operation(), |
a-belhadj
requested changes
Dec 13, 2024
Sispheor
force-pushed
the
perm
branch
3 times, most recently
from
541d768 to
1a9afb5
Compare
a-belhadj
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#724