QA #661

a-belhadj · 2023-09-12T09:04:46Z

No description provided.

Squest/settings.py

Squest/utils/squest_filter.py

service_catalog/filters/global_hook_filter.py

service_catalog/forms/global_hook_forms.py

service_catalog/models/instance.py

service_catalog/models/request.py

Sispheor · 2023-09-13T14:29:56Z

Squest/settings.py

@@ -42,7 +37,7 @@
 DATE_FORMAT = os.environ.get('DATE_FORMAT', "%d %b, %Y  %H:%M")
 LOGIN_HELPER_TEXT = os.environ.get('LOGIN_HELPER_TEXT', None)
 IS_DEV_SERVER = str_to_bool(os.environ.get('IS_DEV_SERVER', False))
-
+SQL_DEBUG = str_to_bool(os.environ.get('SQL_DEBUG', False))


add to doc or remove

Sispheor · 2023-09-13T14:30:15Z

Squest/settings.py

@@ -126,23 +123,22 @@
 # Database
 # https://docs.djangoproject.com/en/3.1/ref/settings/#databases

+DJANGO_DATABASE_NAME = os.environ.get("DJANGO_DATABASE_NAME", 'default')
+DJANGO_DATABASE_ENGINE = os.environ.get("DJANGO_DATABASE_ENGINE", 'django.db.backends.mysql')


Sispheor · 2023-09-13T14:35:14Z

Squest/views.py


    if request.user.has_perm('service_catalog.list_support'):
-        context['total_support_opened'] = all_supports.filter(state='OPENED').count()
+        context['total_support_opened'] = all_supports.filter(state=SupportState.OPENED).count()


remove admin_data.py

Sispheor · 2023-09-13T14:36:05Z

docs/manual/administration/extras.md


 - **name:** Name of your hook
- **Model:** Target model object that will be linked to the hook (`Request` or an `Instance`)
 - **State:** State of the selected `model`. The hook will be triggered when an instance of the select model type will switch to this selected state


to be reviews as model doesn't exist anymore

Sispheor · 2023-09-13T14:40:30Z

profiles/templatetags/squest_utils.py

+                    {
+                        'name': 'Instance hook ',
+                        'view_name': 'service_catalog:instancehook_list',
+                        'icon': 'fas fa-file-code',


Sispheor · 2023-09-13T14:42:16Z

resource_tracker_v2/views/transformer_views.py

@@ -143,5 +143,5 @@ def ajax_load_attribute(request):

    options = [(transformer.attribute_definition.id, transformer.attribute_definition.name) for transformer in
               all_available_attribute_to_target_rg.all()]
-    return render(request, 'service_catalog/settings/global_hooks/state-dropdown-list-option.html',
+    return render(request, 'generics/ajax.html',


ajax_option

Sispheor · 2023-09-13T14:43:20Z

service_catalog/migrations/0023_auto_20230912_1524.py

+    operations = [
+
+        migrations.RunSQL('UPDATE service_catalog_instance SET state = 1 WHERE state = "SUBMITTED";'),
+        migrations.RunSQL('UPDATE service_catalog_instance SET state = 1 WHERE state = "PENDING";'),


should be 2

Sispheor · 2023-09-13T15:36:41Z

tests/test_service_catalog/test_views/test_admin/test_tools/test_request_hook/test_create.py

+    def test_create_valid_request_hook(self):
+        data = {
+            "name": "hook1",
+            "model": "Request",


model is not here anymore

Sispheor · 2023-09-13T15:37:08Z

tests/test_service_catalog/test_views/test_admin/test_tools/test_request_hook/test_edit.py

+    def test_edit_request_hook(self):
+        data = {
+            "name": "hook2",
+            "model": "Request",


Sispheor reviewed Sep 12, 2023

View reviewed changes

Squest/settings.py Outdated Show resolved Hide resolved

a-belhadj force-pushed the QA branch 2 times, most recently from 99fe857 to 3d8634f Compare September 12, 2023 11:28

a-belhadj added 2 commits September 12, 2023 16:12

Use django bulitin cache

fedcdcd

Add SQL_DEBUG in Settings.py

bb09a97

a-belhadj force-pushed the QA branch 9 times, most recently from ff8782a to 32a8d1c Compare September 12, 2023 23:14