Fix bug on permission_required for ConfirmView

HewlettPackard · Dec 14, 2023 · 872676d · 872676d
1 parent 70188ca
commit 872676d
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/Squest/utils/squest_views.py b/Squest/utils/squest_views.py
@@ -256,7 +256,8 @@ def get_success_url(self):
         return self.get_object().get_absolute_url()
 
     def get_permission_required(self):
-        pass
+        if self.permission_required is not None:
+            return self.permission_required
 
     def get_context_data(self, **kwargs):
         self.object = self.get_object()

diff --git a/tests/test_service_catalog/test_urls/test_approvalworkflow.py b/tests/test_service_catalog/test_urls/test_approvalworkflow.py
@@ -51,6 +51,16 @@ def test_approvalworkflow_views(self):
                     'scopes': [self.test_quota_scope.id],
                 }
             ),
+            TestingGetContextView(
+                url='service_catalog:approvalworkflow_reset_requests',
+                perm_str='service_catalog.re_submit_request',
+                url_kwargs={'pk': self.approval_workflow.id}
+            ),
+            TestingPostContextView(
+                url='service_catalog:approvalworkflow_reset_requests',
+                perm_str='service_catalog.re_submit_request',
+                url_kwargs={'pk': self.approval_workflow.id}
+            ),
             TestingGetContextView(
                 url='service_catalog:approvalworkflow_delete',
                 perm_str='service_catalog.delete_approvalworkflow',