hide button without permission

HewlettPackard · Sep 18, 2023 · 0fb5068 · 0fb5068
1 parent 88e96ec
commit 0fb5068
Show file tree

Hide file tree

Showing 19 changed files with 141 additions and 133 deletions.
diff --git a/templates/generics/buttons/add_button.html b/templates/generics/buttons/add_button.html
@@ -1,8 +1,8 @@
 {% with perm=django_content_type.app_label|add:".add_"|add:django_content_type.model %}
     {% has_perm request.user perm as can_add %}
-    <span {% if not can_change %} title="Permission {{ perm }} needed" {% endif %}>
-        <a class="btn btn-success {% if not can_add %} disabled{% endif %}" href="{{ add_url }}">
+    {% if can_add %}
+        <a class="btn btn-success" href="{{ add_url }}">
             <i class="fas fa-plus"></i> Add
         </a>
-    </span>
+    {% endif %}
 {% endwith %}
diff --git a/templates/generics/buttons/bulk_delete_button.html b/templates/generics/buttons/bulk_delete_button.html
@@ -1,4 +1,6 @@
 {% has_perm request.user django_content_type.app_label|add:".delete_"|add:django_content_type.model as can_delete %}
-<button class="btn btn-danger{% if not can_delete %} disabled{% endif %}" type="submit"{% if not can_delete %} disabled{% endif %}>
-    <i class="fas fa-trash"></i> Delete
-</button>
+{% if can_delete %}
+    <a class="btn btn-danger" type="submit">
+        <i class="fas fa-trash"></i> Delete
+    </a>
+{% endif %}
diff --git a/templates/generics/buttons/delete_button.html b/templates/generics/buttons/delete_button.html
@@ -2,12 +2,12 @@
     {% with class=object|to_class_name|lower %}
         {% with perm=app|add:".delete_"|add:class %}
             {% has_perm request.user perm object as can_delete %}
-            <span {% if not can_change %} title="Permission {{ perm }} needed" {% endif %}>
-                <a href="{% url app|add:':'|add:class|add:'_delete' object.id %}"
-                   class="btn btn-danger{% if not can_delete %} disabled{% endif %}">
-                    <i class="fas fa-trash"></i>
-                </a>
-            </span>
+            {% if can_delete %}
+                    <a href="{% url app|add:':'|add:class|add:'_delete' object.id %}"
+                       class="btn btn-danger">
+                        <i class="fas fa-trash"></i>
+                    </a>
+            {% endif %}
         {% endwith %}
     {% endwith %}
 {% endwith %}
diff --git a/templates/generics/buttons/edit_button.html b/templates/generics/buttons/edit_button.html
@@ -2,12 +2,12 @@
     {% with class=object|to_class_name|lower %}
         {% with perm=app|add:".change_"|add:class %}
             {% has_perm request.user perm object as can_change %}
-            <span {% if not can_change %} title="Permission {{ perm }} needed" {% endif %}>
+            {% if can_change %}
                 <a href="{% url app|add:':'|add:class|add:'_edit' object.id %}"
-                   class="btn btn-primary{% if not can_change %} disabled{% endif %}">
+                   class="btn btn-primary">
                     <i class="fas fa-pencil-alt"></i>
                 </a>
-            </span>
+            {% endif %}
         {% endwith %}
     {% endwith %}
 {% endwith %}
diff --git a/templates/generics/custom_columns/generic_delete.html b/templates/generics/custom_columns/generic_delete.html
@@ -2,23 +2,20 @@
     {% with class=record|to_class_name|lower %}
         {% with perm=app|add:".delete_"|add:class %}
             {% has_perm request.user perm as can_delete %}
-            {% if parent_id %}
-                <span {% if not can_delete %} title="Permission {{ perm }} needed" {% endif %}>
-
-                <a href="{% url app|add:":"|add:class|add:"_delete" parent_id record.id %}"
-                   class="btn btn-danger bg-sm{% if not can_delete %} disabled{% endif %}"
-                   title="Delete">
-                    <i class="fas fa-trash"></i>
-                </a>
-            </span>
-            {% else %}
-                <span {% if not can_delete %} title="Permission {{ perm }} needed" {% endif %}>
-                <a href="{% url app|add:":"|add:class|add:"_delete" record.id %}"
-                   class="btn btn-danger bg-sm{% if not can_delete %} disabled{% endif %}"
-                   title="Delete">
-                    <i class="fas fa-trash"></i>
-                </a>
-            </span>
+            {%  if can_delete %}
+                {% if parent_id %}
+                    <a href="{% url app|add:":"|add:class|add:"_delete" parent_id record.id %}"
+                       class="btn btn-danger bg-sm"
+                       title="Delete">
+                        <i class="fas fa-trash"></i>
+                    </a>
+                {% else %}
+                    <a href="{% url app|add:":"|add:class|add:"_delete" record.id %}"
+                       class="btn btn-danger bg-sm"
+                       title="Delete">
+                        <i class="fas fa-trash"></i>
+                    </a>
+                {% endif %}
             {% endif %}
         {% endwith %}
     {% endwith %}

diff --git a/templates/generics/custom_columns/generic_edit.html b/templates/generics/custom_columns/generic_edit.html
@@ -2,23 +2,21 @@
     {% with class=record|to_class_name|lower %}
         {% with perm=app|add:".change_"|add:class %}
             {% has_perm request.user perm as can_change %}
-            {% if parent_id %}
-                <span {% if not can_change %} title="Permission {{ perm }} needed" {% endif %}>
+            {% if can_change %}
+                {% if parent_id %}
 
-                <a href="{% url app|add:":"|add:class|add:"_edit" parent_id record.id %}"
-                   class="btn btn-primary bg-sm{% if not can_change %} disabled{% endif %}"
-                   title="Edit">
-                    <i class="fas fa-pencil-alt"></i>
-                </a>
-            </span>
-            {% else %}
-                <span {% if not can_change %} title="Permission {{ perm }} needed" {% endif %}>
-                <a href="{% url app|add:":"|add:class|add:"_edit" record.id %}"
-                   class="btn btn-primary bg-sm{% if not can_change %} disabled{% endif %}"
-                   title="Edit">
-                    <i class="fas fa-pencil-alt"></i>
-                </a>
-            </span>
+                    <a href="{% url app|add:":"|add:class|add:"_edit" parent_id record.id %}"
+                       class="btn btn-primary bg-sm"
+                       title="Edit">
+                        <i class="fas fa-pencil-alt"></i>
+                    </a>
+                {% else %}
+                    <a href="{% url app|add:":"|add:class|add:"_edit" record.id %}"
+                       class="btn btn-primary bg-sm"
+                       title="Edit">
+                        <i class="fas fa-pencil-alt"></i>
+                    </a>
+                {% endif %}
             {% endif %}
         {% endwith %}
     {% endwith %}

diff --git a/templates/profiles/custom_columns/delete_all_user_roles.html b/templates/profiles/custom_columns/delete_all_user_roles.html
@@ -1,10 +1,10 @@
 {# can_delete_user come from {organization,team,globalpermission}_detail.html#}
 {% with class_name=object|to_class_name|lower %}
-    <span {% if not can_delete_user %} title="Permission 'profiles.delete_role' needed" {% endif %}>
+    {% if can_delete_user %}
         <a href="{% url "profiles:"|add:class_name|add:"_rbac_delete" object.id record.id %}"
-           class="btn btn-danger bg-sm{% if not can_delete_user %} disabled{% endif %}"
+           class="btn btn-danger bg-sm"
            title="Delete">
             <i class="fas fa-trash"></i>
         </a>
-    </span>
+    {% endif %}
 {% endwith %}
diff --git a/templates/profiles/global_permission_default_permission_detail.html b/templates/profiles/global_permission_default_permission_detail.html
@@ -6,10 +6,12 @@
 {% load static %}
 {% block header_button %}
     {% has_perm request.user "profiles.change_globalpermission" object as can_change_global_perm %}
-    <a href="{% url 'profiles:globalpermission_edit' %}"
-       class="btn btn-primary">
-        <i class="fas fa-pencil-alt {% if not can_change_global_perm %} disabled{% endif %}"></i>
-    </a>
+    {% if can_change_global_perm %}
+        <a href="{% url 'profiles:globalpermission_edit' %}"
+           class="btn btn-primary">
+            <i class="fas fa-pencil-alt"></i>
+        </a>
+    {% endif %}
 {% endblock %}
 
 {% block main %}

diff --git a/templates/profiles/globalpermission_rbac_detail.html b/templates/profiles/globalpermission_rbac_detail.html
@@ -6,9 +6,11 @@
 {% load static %}
 {% block extra_header_button %}
     {% has_perm request.user "profiles.add_users_globalpermission" object as can_add_users %}
-    <a href="{% url 'profiles:globalpermission_rbac_create' object.id %}"
-       class="btn btn-success{% if not can_add_users %} disabled{% endif %}"><i class="fas fa-user-plus"></i> Add Global RBAC
-    </a>
+    {% if can_add_users %}
+        <a href="{% url 'profiles:globalpermission_rbac_create' object.id %}"
+           class="btn btn-success"><i class="fas fa-user-plus"></i> Add Global RBAC
+        </a>
+    {% endif %}
 {% endblock %}
 
 {% block main %}

diff --git a/templates/profiles/organization_detail.html b/templates/profiles/organization_detail.html
@@ -9,26 +9,27 @@
     {% has_perm request.user "profiles.add_users_organization" object as can_add_user_in_organization %}
     {% has_perm request.user "profiles.add_team" object as can_add_team %}
     {% has_perm request.user "profiles.change_organization_quota" object as can_change_quota %}
-    <span {% if not can_change_quota %}title="Permission profiles.change_quota needed"{% endif %}>
+    {% if can_change_quota %}
         <a href="{% url 'profiles:organization_quota_edit' object.id %}"
-           class="btn btn-primary{% if not can_change_quota %} disabled{% endif %}">
+           class="btn btn-primary">
             <i class="fas fa-chart-pie"></i> Set quotas
         </a>
-    </span>
+    {% endif %}
 
-    <span {% if not can_add_user_in_organization %}title="Permission profiles.add_users_organization needed"{% endif %}>
+    {% if can_add_user_in_organization %}
         <a href="{% url 'profiles:organization_rbac_create' object.id %}"
-           class="btn btn-success{% if not can_add_user_in_organization %} disabled{% endif %}">
+           class="btn btn-success">
             <i class="fas fa-user-plus"></i> Add Organization RBAC
         </a>
-    </span>
+    {% endif %}
 
-    <span {% if not can_add_team %}title="Permission profiles.add_team needed"{% endif %}>
+    {% if can_add_team %}
         <a href="{% url 'profiles:team_create' %}?org={{ object.id }}"
-           class="btn btn-success{% if not can_add_team %} disabled{% endif %}">
+           class="btn btn-success">
             <i class="fas fa-users"></i> Add team
         </a>
-    </span>
+    {% endif %}
+
 {% endblock %}
 
 {% block header_button %}

diff --git a/templates/profiles/team_detail.html b/templates/profiles/team_detail.html
@@ -7,17 +7,17 @@
 {% block extra_header_button %}
     {% has_perm request.user "profiles.add_users_team" object as can_add_user %}
     {% has_perm request.user "profiles.change_team_quota" object as can_change_quota %}
-    <span {% if not can_change_quota %} title="Permission profiles.change_quota needed" {% endif %}>
-            <a href="{% url 'profiles:team_quota_edit' object.id %}"
-               class="btn btn-primary{% if not can_change_quota %} disabled{% endif %}"> <i
-                    class="fas fa-chart-pie"></i> Set quotas
-            </a>
-    </span>
-    <span {% if not can_add_user %} title="Permission profiles.add_users_team needed" {% endif %}>
-            <a href="{% url 'profiles:team_rbac_create' object.id %}"
-               class="btn btn-success{% if not can_add_user %} disabled{% endif %}"><i class="fas fa-user-plus"></i> Add Team RBAC
-            </a>
-    </span>
+    {% if can_change_quota %}
+        <a href="{% url 'profiles:team_quota_edit' object.id %}"
+           class="btn btn-primary"> <i
+                class="fas fa-chart-pie"></i> Set quotas
+        </a>
+    {% endif %}
+    {% if can_add_user %}
+        <a href="{% url 'profiles:team_rbac_create' object.id %}"
+           class="btn btn-success"><i class="fas fa-user-plus"></i> Add Team RBAC
+        </a>
+    {% endif %}
 {% endblock %}
 {% block header_button %}
     {% include 'generics/buttons/edit_button.html' %}

diff --git a/templates/service_catalog/buttons/delete_operation_button.html b/templates/service_catalog/buttons/delete_operation_button.html
@@ -1,9 +1,9 @@
 {% with perm="service_catalog.delete_operation" %}
     {% has_perm request.user perm object as can_delete %}
-    <span {% if not can_change %} title="Permission {{ perm }} needed" {% endif %}>
-                <a href="{% url 'service_catalog:operation_delete' object.service.id object.id %}"
-                   class="btn btn-danger{% if not can_delete %} disabled{% endif %}">
-                    <i class="fas fa-trash"></i>
-                </a>
-            </span>
+    {% if can_delete %}
+        <a href="{% url 'service_catalog:operation_delete' object.service.id object.id %}"
+           class="btn btn-danger">
+            <i class="fas fa-trash"></i>
+        </a>
+    {% endif %}
 {% endwith %}
diff --git a/templates/service_catalog/buttons/edit_operation_button.html b/templates/service_catalog/buttons/edit_operation_button.html
@@ -1,9 +1,9 @@
 {% with perm="service_catalog.change_operation" %}
     {% has_perm request.user perm object as can_change %}
-    <span {% if not can_change %} title="Permission {{ perm }} needed" {% endif %}>
-                <a href="{% url 'service_catalog:operation_edit' object.service.id object.id %}"
-                   class="btn btn-primary{% if not can_change %} disabled{% endif %}">
-                    <i class="fas fa-pencil-alt"></i>
-                </a>
-            </span>
+    {% if can_change %}
+            <a href="{% url 'service_catalog:operation_edit' object.service.id object.id %}"
+               class="btn btn-primary">
+                <i class="fas fa-pencil-alt"></i>
+            </a>
+    {% endif %}
 {% endwith %}
diff --git a/templates/service_catalog/buttons/instance_buttons.html b/templates/service_catalog/buttons/instance_buttons.html
@@ -19,14 +19,16 @@
         </a>
     {% endif %}
 {% endwith %}
-{% if object.service.external_support_url is not None and object.service.external_support_url != '' %}
-    <a class="btn btn-success {% if not can_add_support %}disabled{% endif %}"
-       href="{% url 'service_catalog:support_create' object.id %}">
-        <i class="fas fa-link"></i> Open new support
-    </a>
-{% else %}
-    <a class="btn btn-success {% if not can_add_support %}disabled{% endif %}"
-       href="{% url 'service_catalog:support_create' object.id %}">
-        <i class="fas fa-plus"></i> Open new support
-    </a>
+{% if can_add_support %}
+    {% if object.service.external_support_url is not None and object.service.external_support_url != '' %}
+        <a class="btn btn-success"
+           href="{% url 'service_catalog:support_create' object.id %}">
+            <i class="fas fa-link"></i> Open new support
+        </a>
+    {% else %}
+        <a class="btn btn-success"
+           href="{% url 'service_catalog:support_create' object.id %}">
+            <i class="fas fa-plus"></i> Open new support
+        </a>
+    {% endif %}
 {% endif %}
diff --git a/templates/service_catalog/buttons/operation_survey_button.html b/templates/service_catalog/buttons/operation_survey_button.html
@@ -1,7 +1,7 @@
 {% has_perm request.user "service_catalog.change_operation" as can_change %}
-<span {% if not can_change %} title="Permission service_catalog.change_operation needed" {% endif %}>
-    <a href="{% url 'service_catalog:operation_edit_survey' service_id=object.service.id pk=object.id %}"
-       class="btn btn-default bg-sm {% if not can_change %} disabled {% endif %}">
-        <i class="fas fa-clipboard-list"></i> Survey
-    </a>
-</span>
+{% if can_change %}
+        <a href="{% url 'service_catalog:operation_edit_survey' service_id=object.service.id pk=object.id %}"
+           class="btn btn-default bg-sm">
+            <i class="fas fa-clipboard-list"></i> Survey
+        </a>
+{% endif %}
diff --git a/templates/service_catalog/common/instance-support-details.html b/templates/service_catalog/common/instance-support-details.html
@@ -5,6 +5,7 @@
 {% load static %}
 {% block content %}
     {% has_perm request.user "service_catalog.add_supportmessage" instance as can_comment_support %}
+    {% has_perm request.user "service_catalog.reopen_support" instance as can_reopen_support %}
     {% has_perm request.user "service_catalog.close_support" instance as can_close_support %}
     {% has_perm request.user "service_catalog.change_support" instance as can_change_support %}
     <!-- Main content -->
@@ -69,15 +70,15 @@
                                         </div>
                                     </form>
                                 {% endif %}
-                                {% if support.get_state_display == "OPENED" %}
+                                {% if support.get_state_display == "OPENED" and can_close_support %}
                                     <a href="{% url 'service_catalog:support_close' instance_id=instance.id pk=support.id %}"
-                                       class="btn btn-danger{% if not can_close_support %} disabled{% endif %}">
+                                       class="btn btn-danger">
                                         <i class="fas fa-times-circle"></i> Close
                                     </a>
                                 {% endif %}
-                                {% if support.get_state_display == "CLOSED" %}
+                                {% if support.get_state_display == "CLOSED" and can_reopen_support %}
                                     <a href="{% url 'service_catalog:support_reopen' instance_id=instance.id pk=support.id %}"
-                                       class="btn btn-success{% if not can_change_support %} disabled{% endif %}">
+                                       class="btn btn-success">
                                         <i class="fas fa-undo"></i> Re-open
                                     </a>
                                 {% endif %}

diff --git a/templates/service_catalog/custom_columns/create_operation_request.html b/templates/service_catalog/custom_columns/create_operation_request.html
@@ -3,10 +3,9 @@
 {% else %}
     {% has_perm request.user "service_catalog.request_on_service" as can_request_operation %}
 {% endif %}
-
-<span {% if not can_request_operation %}title="Permission {% if record.is_admin_operation %}service_catalog.admin_request_on_service{% else %}service_catalog.request_on_service{% endif %} required"{% endif %}>
-<a href="{% url 'service_catalog:request_service' service_id=service_id operation_id=record.id %}"
-   class="btn btn-info bg-sm {% if not can_request_operation %}disabled{% endif %}">
-    <i class="fas fa-shopping-cart"></i>
-</a>
-</span>
+{% if can_request_operation %}
+    <a href="{% url 'service_catalog:request_service' service_id=service_id operation_id=record.id %}"
+       class="btn btn-info bg-sm">
+        <i class="fas fa-shopping-cart"></i>
+    </a>
+{% endif %}
diff --git a/templates/service_catalog/custom_columns/operation_actions.html b/templates/service_catalog/custom_columns/operation_actions.html
@@ -1,10 +1,10 @@
 {% has_perm request.user "service_catalog.change_operation" as can_change %}
-<span {% if not can_change %} title="Permission service_catalog.change_operation needed" {% endif %}>
-    <a href="{% url 'service_catalog:operation_edit_survey' service_id=record.service.id pk=record.id %}"
-       class="btn btn-primary bg-sm {% if not can_change %} disabled {% endif %}">
-        <i class="fas fa-clipboard-list"></i>
-    </a>
-</span>
+{% if can_change %}
+        <a href="{% url 'service_catalog:operation_edit_survey' service_id=record.service.id pk=record.id %}"
+           class="btn btn-primary bg-sm">
+            <i class="fas fa-clipboard-list"></i>
+        </a>
+{% endif %}
 {% with parent_id=record.service.id %}
     {% include 'generics/custom_columns/generic_actions.html' %}
 {% endwith %}