Skip to content

Commit

Permalink
prov/cxi: update unit test for collectives
Browse files Browse the repository at this point in the history 
Update the unit tests for collectives to account for previously-merged
PR: ofiwg#10513

Signed-off-by: John Heemstra <[email protected]>
  • Loading branch information
@heemstra @iziemba
heemstra authored and iziemba committed Nov 13, 2024
1 parent 33e8e86 commit 39c2f97
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions prov/cxi/test/coll.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2032,7 +2032,7 @@ Test(coll_reduce_ops, fmin)
ret = _check_fval(nodes, rslt, &check);
cr_assert(!ret, "compare failed NAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_OVERFLOW);
cr_assert(!ret, "rc failed NAN\n");
cr_assert(ret, "rc NAN succeeded\n");

data[1].fval[1] = _snan64();
_predict_fmin(nodes, data, &check, true);
Expand All @@ -2041,7 +2041,7 @@ Test(coll_reduce_ops, fmin)
ret = _check_fval(nodes, rslt, &check);
cr_assert(!ret, "compare failed sNAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_INVALID);
cr_assert(!ret, "rc failed sNAN\n");
cr_assert(ret, "rc sNAN succeeded\n");
STDCLEANUP
}

Expand Down Expand Up @@ -2070,7 +2070,7 @@ Test(coll_reduce_ops, fmax)
ret = _check_fval(nodes, rslt, &check);
cr_assert(!ret, "compare failed NAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_OVERFLOW);
cr_assert(!ret, "rc failed NAN\n");
cr_assert(ret, "rc NAN succeeded\n");

data[1].fval[1] = _snan64();
_predict_fmax(nodes, data, &check, true);
Expand All @@ -2079,7 +2079,7 @@ Test(coll_reduce_ops, fmax)
ret = _check_fval(nodes, rslt, &check);
cr_assert(!ret, "compare failed sNAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_INVALID);
cr_assert(!ret, "rc failed sNAN\n");
cr_assert(ret, "rc sNAN succeeded\n");
STDCLEANUP
}

Expand Down Expand Up @@ -2134,7 +2134,7 @@ Test(coll_reduce_ops, fminmaxloc)
ret = _check_fminmax(nodes, rslt, &check);
cr_assert(!ret, "compare failed sNAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_INVALID);
cr_assert(!ret, "rc failed sNAN\n");
cr_assert(ret, "rc sNAN succeeded\n");
STDCLEANUP
}

Expand Down Expand Up @@ -2166,7 +2166,7 @@ Test(coll_reduce_ops, fminnum)
ret = _check_fval(nodes, rslt, &check);
cr_assert(!ret, "compare failed NAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_OVERFLOW);
cr_assert(!ret, "rc failed NAN\n");
cr_assert(ret, "rc NAN succeeded\n");

/* number is given preference over NAN */
data[1].fval[1] = _snan64();
Expand All @@ -2177,7 +2177,7 @@ Test(coll_reduce_ops, fminnum)
ret = _check_fval(nodes, rslt, &check);
cr_assert(!ret, "compare failed sNAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_INVALID);
cr_assert(!ret, "rc failed sNAN\n");
cr_assert(ret, "rc sNAN succeeded\n");
STDCLEANUP
}

Expand Down Expand Up @@ -2209,7 +2209,7 @@ Test(coll_reduce_ops, fmaxnum)
ret = _check_fval(nodes, rslt, &check);
cr_assert(!ret, "compare failed NAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_OVERFLOW);
cr_assert(!ret, "rc failed NAN\n");
cr_assert(ret, "rc NAN succeeded\n");

/* SNAN is given preference over number */
data[1].fval[1] = _snan64();
Expand All @@ -2220,7 +2220,7 @@ Test(coll_reduce_ops, fmaxnum)
ret = _check_fval(nodes, rslt, &check);
cr_assert(!ret, "compare failed sNAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_INVALID);
cr_assert(!ret, "rc failed sNAN\n");
cr_assert(ret, "rc sNAN succeeded\n");
STDCLEANUP
}

Expand Down Expand Up @@ -2275,7 +2275,7 @@ Test(coll_reduce_ops, fminmaxnumloc)
ret = _check_fminmax(nodes, rslt, &check);
cr_assert(!ret, "compare failed sNAN\n");
ret = _check_rc(nodes, context, FI_CXI_ERRNO_RED_FLT_INVALID);
cr_assert(!ret, "rc failed sNAN\n");
cr_assert(ret, "rc sNAN succeeded\n");
STDCLEANUP
}

Expand Down

0 comments on commit 39c2f97

Please sign in to comment.