Device-write efficiency improvements #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Maintain type consistency to avoid unnecessary type conversion - Early returns to simplify control flow and reduce branching - Eliminate redundant checks
|
Btw, it would be nice if someone does test this, to show me for my own morbid curiosity what performance uplift this gives :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve device write efficiency.
device_writecurrently does unnecessary type conversion forrctoint, and has redundant checks increasing branching.This version allows early return, more efficient error handling, and prevents unnecessary type conversion.
We do cast
rctosize_t, but a cast is effectively free from a performance standpoint and we did the check to see if it was a negative value beforehand anyway.Design Documents
Related JIRAs
Risk
LOW - The function has the same core functionality, it is only more efficient.
Tests
Unable to test - Code inspection only. Highly recommend testing.