Merge pull request #257 from HewlettPackard/schema-fix

Show errors on changing template_id and storage_type

internal/cmp/instance_helper.go

@@ -360,6 +360,9 @@ func instanceCompareVolumes(org, new []map[string]interface{}) ([]map[string]int
 				if new[i]["size"].(int) < org[j]["size"].(int) {
 					return nil, fmt.Errorf("storage volume %s of the instance can't be reduced", new[i]["name"])
 				}
+				if new[i]["storage_type"] != org[j]["storage_type"] {
+					return nil, fmt.Errorf("storage type of volume %s can't be changed", new[i]["name"])
+				}
 
 				break
 			}

internal/resources/diffValidation/resource_instances.go

@@ -1,4 +1,4 @@
-//  (C) Copyright 2021 Hewlett Packard Enterprise Development LP
+//  (C) Copyright 2021-2024 Hewlett Packard Enterprise Development LP
 
 package diffvalidation
 
@@ -70,6 +70,15 @@ func (i *Instance) instanceTemplateValidate() error {
 			if templateID == 0 {
 				return fmt.Errorf("template_id is required for 'vmware' instance type code")
 			}
+			oldConfig, _ := i.diff.GetChange("config")
+			oldTemplateID := templateID
+			oldConfigList := oldConfig.(*schema.Set).List()
+			if len(oldConfigList) > 0 {
+				oldTemplateID = oldConfigList[0].(map[string]interface{})["template_id"].(int)
+			}
+			if oldTemplateID != templateID {
+				return fmt.Errorf("template_id of an instance can't be changed")
+			}
 		}
 	}
 

internal/resources/resource_instances_helper.go

@@ -147,7 +147,6 @@ func getInstanceDefaultSchema(isClone bool) *schema.Resource {
 							Optional: true,
 							Description: `Storage type ID can be obtained from hpegl_vmaas_instance_disk_type
 							data source.`,
-							DiffSuppressFunc: utils.SkipField(),
 						},
 						"id": {
 							Computed:    true,