GO SDK for DHCP based NSX-T segment #61
Conversation
| Site IDStringModel `json:"site,omitempty"` | ||
| Type IDModel `json:"type,omitempty"` | ||
| NetworkDomain *IDModel `json:"networkDomain,omitempty"` | ||
| NetworkProxy *IDModel `json:"networkProxy,omitempty"` |
There was a problem hiding this comment.
why did you remove these ? We still have support for Static Pool Networks. Did the story say that we need to remove static pool networks anywhere ?
| Gateway string `json:"gateway,omitempty" tf:"gateway"` | ||
| DNSPrimary string `json:"dnsPrimary,omitempty" tf:"primary_dns"` | ||
| DNSSecondary string `json:"dnsSecondary,omitempty" tf:"secondary_dns"` | ||
| Config *CreateNetworkConfig `json:"config,omitempty" tf:"config,sub"` | ||
| Config *CreateNetworkConfig `json:"config" tf:"config,sub"` | ||
| Active bool `json:"active" tf:"active"` |
There was a problem hiding this comment.
my only worry about changing the tf fields is that it could break the existing automation if any of the teams have used ? what is the need to change the tf fields which were already existing ? Please have a good explanation about this.
There was a problem hiding this comment.
Use can create both DHCP and Static Networks. Ideally he should be able to create one at a time. Please add necessary validations for the same.
https://turbo-fortnight-4dcdc26d.pages.github.io/#tag/Networks/operation/CreatesANetwork
There was a problem hiding this comment.
updated the proper model for both DHCP and Static Networks.
pkg/models/shared_models.go
Outdated
| @@ -5,11 +5,11 @@ package models | |||
| import "encoding/json" | |||
|
|
|||
| type IDModel struct { | |||
| ID int `json:"id,omitempty" tf:"id"` | |||
There was a problem hiding this comment.
this is being used in many places, I hope this doesnt break anything. why do we need to remove omit_empty here ?
pkg/models/networks.go
Outdated
| } | ||
|
|
||
| type CreateStaticNetwork struct { | ||
| ExternalID string `json:"-" tf:"external_id,computed"` |
There was a problem hiding this comment.
why do need these to be tf fields ?
There was a problem hiding this comment.
InternalID, Unique ID , External ID
| SubnetIPServerID string `json:"subnetIpServerId"` | ||
| SubnetDhcpServerAddress string `json:"subnetDhcpServerAddress"` | ||
| DhcpRange string `json:"dhcpRange"` | ||
| SubnetDhcpLeaseTime string `json:"subnetDhcpLeaseTime"` |
There was a problem hiding this comment.
why is lease time a string ?
No description provided.