Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router route APIs #29

Merged
merged 9 commits into from
Nov 26, 2021
Merged

Router route APIs #29

merged 9 commits into from
Nov 26, 2021

Conversation

tshihad
Copy link
Contributor

@tshihad tshihad commented Nov 18, 2021

Code changes

  • Appending host and base URL is moved into do function since this is a redundant operation
  • Added id to SuccessOrErrorMessage struct
  • Fix UTs
  • Added Router route APIs
  • UT (TODO)

Copy link
Contributor

@manjunath-batakurki manjunath-batakurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@manjunath-batakurki manjunath-batakurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@manjunath-batakurki manjunath-batakurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gandharvas gandharvas merged commit ce2d9e0 into master Nov 26, 2021
@gandharvas gandharvas deleted the static-router branch November 26, 2021 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants