Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for versioning of API #28

Merged
merged 8 commits into from
Nov 15, 2021
Merged

Support for versioning of API #28

merged 8 commits into from
Nov 15, 2021

Conversation

tshihad
Copy link
Contributor

@tshihad tshihad commented Nov 10, 2021

Description

With this PR we are going to support versioning of APIs. Thus developer can define API's compatible version. Please note that this is a initial implementation.

How it works

While defining api struct, define compatible version string in format "xx.xx.xx" (eg: 5.2.11). Any other format is not supported now.
Any version less than compatible version will returns compatible error.

Code changes

  • Implementation of sdk versioning
  • Move authentication into sdk
  • Fix UT

@tshihad tshihad changed the title CMP versioning in SDK Support for versioning of API Nov 15, 2021
Copy link
Contributor

@manjunath-batakurki manjunath-batakurki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gandharvas gandharvas merged commit 6d03b2d into master Nov 15, 2021
@gandharvas gandharvas deleted the US29800 branch July 5, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants