Add context dealine when calling token APIs #126
Merged
+123
−49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we extensively rework the DoRetries function in pkg/token-util:
The objective of the above is to cancel requests that have stalled for 3 seconds and then retry. This is to help alleviate errors we are seeing with IAM token generation requests that stall.
We've had to rework the calls to DoRetries from issuertoken and identitytoken.
We've also had to rework unit-tests. We've included a new unit-test to check that a DeadlineExceeded error from the request context will be retried.