Skip to content
This repository has been archived by the owner on Feb 26, 2025. It is now read-only.

Query filter for /secrets should use single quotes #82

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Query filter for /secrets should use single quotes #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/datasources/secret/data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func (s *DataSource) Configure(
}

func createNameFilter(name string) string {
return constants.NameFilter + name
return constants.NameFilter + "'" + name + "'"
}

func getSecretByName(
Expand Down
4 changes: 2 additions & 2 deletions internal/simulator/secret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,15 @@ func simulateSecretGetByName() {

gock.New("http://localhost").
Get("/data-services/v1beta1/secrets").
MatchParam("filter", "name eq "+secretName).
MatchParam("filter", "name eq "+"'"+secretName+"'").
MatchHeader("Authorization", "Bearer abcdefghijklmnopqrstuvwxyz-0123456789").
Reply(200).
SetHeader("Content-Type", "application/json").
BodyString(secretByName)

gock.New("http://localhost").
Get("/data-services/v1beta1/secrets").
MatchParam("filter", "name eq "+secretName).
MatchParam("filter", "name eq "+"'"+secretName+"'").
MatchHeader("Authorization", "Bearer expired-token").
Reply(401).
SetHeader("Content-Type", "text/plain").
Expand Down