Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make variables to build FIPS binary #186

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Conversation

chaitra-mylarappachar
Copy link
Contributor

@chaitra-mylarappachar chaitra-mylarappachar commented Apr 3, 2024

Enabled passing FIPS_BUILD Make variable to build FIPS-compliant Go plugin binary.
When FIPS_BUILD is set, CGO_ENABLED, GOLANG_FIPS will be set to 1 while building Go binaries as per the guidelines here -
https://rndwiki-pro.its.hpecorp.net/display/HCSS/Building+fips+compliant+GoLang+binaries

This variable is set while building FIPS binaries from quake's CI jobs ( quake/script/ci-build)

echo "LINUX-ONLY: building ${BIN_NAME} at location ${dir}."
BIN_PATH=bundles/x86_64/linux/ && mkdir -p ${BIN_PATH}
(cd ${dir}; GOOS=$OS_LINUX make build FIPS_BUILD=1)

US63619: build FIPS compatible binaries - qcli, standalone TF

@chaitra-mylarappachar chaitra-mylarappachar marked this pull request as ready for review April 3, 2024 17:03
@chaitra-mylarappachar chaitra-mylarappachar requested a review from a team as a code owner April 3, 2024 17:03
Copy link
Contributor

@anurag-shrivastav anurag-shrivastav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaitra-mylarappachar chaitra-mylarappachar merged commit 5fec908 into master Apr 10, 2024
2 checks passed
@chaitra-mylarappachar chaitra-mylarappachar deleted the Chaitra_fipsbuild branch April 10, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants