Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US69000: Adding extra fields for external volume import #128

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Conversation

achu-1612
Copy link
Contributor

@achu-1612 achu-1612 commented Aug 27, 2024

Description:

Adding extra fields support for external volume import-

  • CapacityUsed
  • UnmanagedVolume
  • ActiveSite
  • CreatedSite
  • ReplicationEnabled

Testing:

  • I updated the metal client after these changes were made, in the quake vendor repo.
  • Created a volume
  • I edited the db recorded to populate random data for the newly added fields in the volume model.
  • I used the /v1 API to test whether those fields were getting fetched.
    Screenshot 2024-08-27 162452

@achu-1612 achu-1612 changed the title volume: field for external vol import US69000: Adding extra fields for external volume import Aug 27, 2024
@achu-1612 achu-1612 requested a review from mchuang3 August 27, 2024 10:48
@achu-1612 achu-1612 marked this pull request as ready for review August 27, 2024 11:07
@achu-1612 achu-1612 requested a review from chitranm August 27, 2024 11:08
@achu-1612 achu-1612 added the enhancement New feature or request label Aug 27, 2024
@achu-1612 achu-1612 requested a review from dbozzato81 August 27, 2024 12:51
@mchuang3
Copy link
Contributor

@chitranm
Copy link
Contributor

NOTE: requires hpe-hcss/quake#4713

I have merged the model changes PR.

@achu-1612 achu-1612 merged commit 77c13cf into master Aug 29, 2024
2 checks passed
@achu-1612 achu-1612 deleted the US69000 branch August 29, 2024 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants