Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to add project API support for FC host WWPNs. #102

Merged
merged 8 commits into from
Jan 30, 2024
Merged

Changes to add project API support for FC host WWPNs. #102

merged 8 commits into from
Jan 30, 2024

Conversation

chitranm
Copy link
Contributor

mchuang3
mchuang3 requested changes Jan 23, 2024
View reviewed changes
v1/api/swagger/components/schemas/Host.yaml Outdated Show resolved Hide resolved
v1/api/swagger/components/schemas/NewHost.yaml Outdated Show resolved Hide resolved
v1/pkg/client/model_host.go Outdated Show resolved Hide resolved
v1/pkg/client/api/openapi.yaml Outdated Show resolved Hide resolved
@shi98382
Copy link

@mchuang3 this change might need to be further confirmed with Dilip in term of priority. Agree to block for now.

@chitranm
Copy link
Contributor Author

@mchuang3 this change might need to be further confirmed with Dilip in term of priority. Agree to block for now.

@shi98382 and @mchuang3, does "Agree to block for now" means that I don't have to work on it now?

@mchuang3
Copy link
Contributor

@mchuang3 this change might need to be further confirmed with Dilip in term of priority. Agree to block for now.

@shi98382 and @mchuang3, does "Agree to block for now" means that I don't have to work on it now?

@chitranm no, it just means we're blocking until the comments are addressed. Please update PR according to Harris's comments, regarding wordings & sample WWPN values. Thanks.

mchuang3
mchuang3 reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@mchuang3 mchuang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shi98382 looks like all your comments have been addressed. Please review again and approve if you have no other issues. Once you approve, I'll remove my block. Thanks.

@chitranm chitranm merged commit d9af80d into master Jan 30, 2024
2 checks passed
@chitranm chitranm deleted the US60196_hpegl_project_api_client branch January 30, 2024 15:20
mchuang3
mchuang3 reviewed Feb 2, 2024
View reviewed changes
v1/api/swagger/components/schemas/NewHost.yaml
Comment on lines +152 to +159
WWPNs:
type: array
description: FC HBA world wide port names
items:
type: string
example:
- 20:31:01:02:ad:f2:a8:e5
- 21:31:01:02:ad:f2:a8:e5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chitranm This should be removed from here since this is for creating new Hosts. WWPNs are h/w info that the user should not provide. Sorry I missed this previously.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mchuang3. So I should remove it only from NewHost.yaml right? And keep the changes in Host.yaml as is?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mchuang3. So I should remove it only from NewHost.yaml right? And keep the changes in Host.yaml as is?

Yes, remove from user Create request only for Hosts, which is NewHost.yml.

@chitranm chitranm mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mchuang3 mchuang3 mchuang3 approved these changes

@harinathakotha harinathakotha harinathakotha approved these changes

@shi98382 shi98382 shi98382 approved these changes

@chaitra-mylarappachar chaitra-mylarappachar Awaiting requested review from chaitra-mylarappachar chaitra-mylarappachar is a code owner

@dbozzato81 dbozzato81 Awaiting requested review from dbozzato81 dbozzato81 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chitranm @shi98382 @mchuang3 @harinathakotha