Skip to content

Commit

Permalink
address review comment
Browse files Browse the repository at this point in the history
  • Loading branch information
ron-saito committed Dec 11, 2024
1 parent 884c754 commit 0cd84a8
Show file tree
Hide file tree
Showing 6 changed files with 28 additions and 20 deletions.
8 changes: 6 additions & 2 deletions v1/api/swagger/components/schemas/Host.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@ allOf:
- SummaryStatus
- Labels
- WWPNs
- FWBaselineID
- FWBaselineVersion
- AvailableFWBaselineID
- AvailableFWBaselineVersion
properties:
Description:
type: string
Expand Down Expand Up @@ -200,12 +204,12 @@ allOf:
example:
- 20:31:01:02:ad:f2:a8:e5
- 21:31:01:02:ad:f2:a8:e5
InstalledFWBaselineID:
FWBaselineID:
type: string
format: uuid
description: >-
The ID of the firmware baseline that is installed on the host.
InstalledFWBaselineVersion:
FWBaselineVersion:
type: string
description: >-
The version of the firmware baseline that is installed on the host.
Expand Down
8 changes: 6 additions & 2 deletions v1/pkg/client/api/openapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7113,11 +7113,11 @@ components:
items:
type: string
type: array
InstalledFWBaselineID:
FWBaselineID:
description: The ID of the firmware baseline that is installed on the host.
format: uuid
type: string
InstalledFWBaselineVersion:
FWBaselineVersion:
description: The version of the firmware baseline that is installed on the
host.
type: string
Expand All @@ -7134,9 +7134,13 @@ components:
required:
- Alert
- AlertInfo
- AvailableFWBaselineID
- AvailableFWBaselineVersion
- Connections
- Deleted
- Description
- FWBaselineID
- FWBaselineVersion
- ISCSIConfig
- Labels
- LocationID
Expand Down
8 changes: 4 additions & 4 deletions v1/pkg/client/docs/Host.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,10 @@ Name | Type | Description | Notes
**SummaryStatus** | [**HealthStatus**](HealthStatus.md) | |
**Labels** | **map[string]string** | The map of label name to label value for the resource. |
**WWPNs** | **[]string** | FC HBA world wide port names |
**InstalledFWBaselineID** | **string** | The ID of the firmware baseline that is installed on the host. | [optional]
**InstalledFWBaselineVersion** | **string** | The version of the firmware baseline that is installed on the host. | [optional]
**AvailableFWBaselineID** | **string** | The ID of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available. | [optional]
**AvailableFWBaselineVersion** | **string** | The version of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available. | [optional]
**FWBaselineID** | **string** | The ID of the firmware baseline that is installed on the host. |
**FWBaselineVersion** | **string** | The version of the firmware baseline that is installed on the host. |
**AvailableFWBaselineID** | **string** | The ID of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available. |
**AvailableFWBaselineVersion** | **string** | The version of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available. |

[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

Expand Down
8 changes: 4 additions & 4 deletions v1/pkg/client/docs/HostAllOf.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@ Name | Type | Description | Notes
**SummaryStatus** | [**HealthStatus**](HealthStatus.md) | |
**Labels** | **map[string]string** | The map of label name to label value for the resource. |
**WWPNs** | **[]string** | FC HBA world wide port names |
**InstalledFWBaselineID** | **string** | The ID of the firmware baseline that is installed on the host. | [optional]
**InstalledFWBaselineVersion** | **string** | The version of the firmware baseline that is installed on the host. | [optional]
**AvailableFWBaselineID** | **string** | The ID of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available. | [optional]
**AvailableFWBaselineVersion** | **string** | The version of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available. | [optional]
**FWBaselineID** | **string** | The ID of the firmware baseline that is installed on the host. |
**FWBaselineVersion** | **string** | The version of the firmware baseline that is installed on the host. |
**AvailableFWBaselineID** | **string** | The ID of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available. |
**AvailableFWBaselineVersion** | **string** | The version of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available. |

[[Back to Model list]](../README.md#documentation-for-models) [[Back to API list]](../README.md#documentation-for-api-endpoints) [[Back to README]](../README.md)

Expand Down
8 changes: 4 additions & 4 deletions v1/pkg/client/model_host.go
Original file line number Diff line number Diff line change
Expand Up @@ -81,11 +81,11 @@ type Host struct {
// FC HBA world wide port names
WWPNs []string `json:"WWPNs"`
// The ID of the firmware baseline that is installed on the host.
InstalledFWBaselineID string `json:"InstalledFWBaselineID,omitempty"`
FWBaselineID string `json:"FWBaselineID"`
// The version of the firmware baseline that is installed on the host.
InstalledFWBaselineVersion string `json:"InstalledFWBaselineVersion,omitempty"`
FWBaselineVersion string `json:"FWBaselineVersion"`
// The ID of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available.
AvailableFWBaselineID string `json:"AvailableFWBaselineID,omitempty"`
AvailableFWBaselineID string `json:"AvailableFWBaselineID"`
// The version of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available.
AvailableFWBaselineVersion string `json:"AvailableFWBaselineVersion,omitempty"`
AvailableFWBaselineVersion string `json:"AvailableFWBaselineVersion"`
}
8 changes: 4 additions & 4 deletions v1/pkg/client/model_host_all_of.go
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ type HostAllOf struct {
// FC HBA world wide port names
WWPNs []string `json:"WWPNs"`
// The ID of the firmware baseline that is installed on the host.
InstalledFWBaselineID string `json:"InstalledFWBaselineID,omitempty"`
FWBaselineID string `json:"FWBaselineID"`
// The version of the firmware baseline that is installed on the host.
InstalledFWBaselineVersion string `json:"InstalledFWBaselineVersion,omitempty"`
FWBaselineVersion string `json:"FWBaselineVersion"`
// The ID of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available.
AvailableFWBaselineID string `json:"AvailableFWBaselineID,omitempty"`
AvailableFWBaselineID string `json:"AvailableFWBaselineID"`
// The version of the firmware baseline that is available for the host. This field is only populated when there is a new firmware baseline available.
AvailableFWBaselineVersion string `json:"AvailableFWBaselineVersion,omitempty"`
AvailableFWBaselineVersion string `json:"AvailableFWBaselineVersion"`
}

0 comments on commit 0cd84a8

Please sign in to comment.