Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting Database Column Renaming from PR #235 #241

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

maxlambrecht
Copy link
Contributor

Pull request check list

  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

Description of change

This PR rectifies an issue from PR #235, where a database column was incorrectly renamed in the initial SQL file, potentially causing migration issues.

Changes in this PR include:

  • Reversion of the column name change in the initial SQL file.
  • Creation of a new migration script for proper column renaming.
  • Update to the currentDBVersion to account for the new migration.

Which issue this pull requests fixes

Signed-off-by: Max Lambrecht <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@Victorblsilveira Victorblsilveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@maxlambrecht maxlambrecht merged commit d091831 into HewlettPackard:main Jul 18, 2023
@maxlambrecht maxlambrecht deleted the create-db-migration branch July 18, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants