Fix issue with server socket_path
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Lambrecht <[email protected]>
maxlambrecht
requested review from
wibarre,
mchurichi,
jufantozzi,
mgbcaio and
Victorblsilveira
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
maxlambrecht
pushed a commit
that referenced
this pull request
Jun 7, 2023
Signed-off-by: Max Lambrecht <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request check list
Affected functionality
Previously, the
galadriel-server runcommand did not utilize thesocket_pathproperty from the config file due to thesocketPathflag taking precedence over the config file, even with a default value set.The issue has been resolved by removing the default value for the
socketPathflag in the run command. As a result, thegaladriel-servernow correctly utilizes thesocket_pathproperty when executing the run command.Description of change
Which issue this pull requests fixes