Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harvester admin API specification #170

Merged
merged 1 commit into from
May 24, 2023
Merged

Harvester admin API specification #170

merged 1 commit into from
May 24, 2023

Conversation

maxlambrecht
Copy link
Contributor

Pull request check list

  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

Description of change

This pull request introduces a new yaml configuration file related to the Galadriel Harvester API.

New API for Harvester's admin:

  • A new yaml file (admin.yaml): This file defines the structure and operations of the API, such as getting relationship details and patching relationships.
  • A new yaml configuration file (admin.cfg.yaml): This file contains package details and instructions on what to generate, and it sets the import mapping and output details.

Regarding the changes in the Makefile:

  • Include the new yaml in the API code generation
  • Formatting changes have been made to standardize variable assignment syntax.
  • Usage of "shell" has been standardized.
  • Comments and help descriptions are updated for clarity.
  • Changing target names for generating SQL and API code, making them consistent.

Which issue this pull requests fixes

@maxlambrecht
Defining Harvester admin API
f8b5b6d 
Signed-off-by: Max Lambrecht <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mgbcaio
mgbcaio approved these changes May 24, 2023
View reviewed changes
Copy link
Collaborator

@mgbcaio mgbcaio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maxlambrecht maxlambrecht merged commit dcd6380 into HewlettPackard:main May 24, 2023
@maxlambrecht maxlambrecht deleted the harvester-api branch May 24, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgbcaio mgbcaio mgbcaio approved these changes

@wibarre wibarre Awaiting requested review from wibarre wibarre is a code owner

@mchurichi mchurichi Awaiting requested review from mchurichi mchurichi is a code owner

@jufantozzi jufantozzi Awaiting requested review from jufantozzi jufantozzi is a code owner

@Victorblsilveira Victorblsilveira Awaiting requested review from Victorblsilveira Victorblsilveira is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxlambrecht @mgbcaio