Keymanager 'disk' implementation #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlambrecht
requested review from
wibarre,
mchurichi,
jufantozzi,
mgbcaio and
Victorblsilveira
as code owners
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
maxlambrecht
force-pushed
the
keymanager-disk-implementation
branch
from
64e61cc to
2db4cb4
Compare
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
mgbcaio
reviewed
May 20, 2023
pkg/common/keymanager/disk.go
Outdated
| return nil | ||
| } | ||
|
|
||
| // SaveKeysToDisk saves the keys in the key manager to disk. |
There was a problem hiding this comment.
Suggested change
| // SaveKeysToDisk saves the keys in the key manager to disk. | |
| // saveKeysToDisk saves the keys in the key manager to disk. |
pkg/common/keymanager/keymanager.go
Outdated
Comment on lines
11
to
12
| // KeyManager provides a common interface for managing keys. | ||
| // Memory provides a common interface for managing keys. | ||
| type KeyManager interface { |
There was a problem hiding this comment.
Change interface name to match the new comment ?
There was a problem hiding this comment.
No, the comment is wrong.
Signed-off-by: Max Lambrecht <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
mgbcaio
approved these changes
May 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request check list
Affected functionality
Add a new
KeyManageroption for managing Keys in the Galadriel Server. This options adds the possibility of restarting the Galadriel Server without affecting the onboarded Harvesters, as the Server will be able to continue validating the issued JWT tokens.Description of change
Implementation of a
KeyManagerthat stores keys in disk.Which issue this pull requests fixes