Add SQLite3 support #157
Merged
Add SQLite3 support #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxlambrecht
requested review from
wibarre,
mchurichi,
jufantozzi,
mgbcaio and
Victorblsilveira
as code owners
…#150) Implementing Admin Handlers Signed-off-by: Victor Vieira Barros Leal da Silveira <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Victorblsilveira
approved these changes
May 16, 2023
Signed-off-by: Max Lambrecht <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
I had done it already in the second or third commit. Now I removed the TODO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request check list
Affected functionality
Add support for SQLite datastore.
Convert the connection string config for the datastore to a
Datastoreblock in theproviders, supporting typespostgresandsqlite3.Description of change
Move the Datastore to the Catalog.
Add migrations and queries SQLs files for SQLite.
Refactor tests to run common test code for postgres and sqlite engines.
Improve some struct names.
Which issue this pull requests fixes