Implement Harvester API handlers #154
Conversation
maxlambrecht
requested review from
wibarre,
mchurichi,
jufantozzi,
mgbcaio and
Victorblsilveira
as code owners
maxlambrecht
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
maxlambrecht
force-pushed
the
feature/harvester-get-relationships
branch
from
00e4342 to
7bfa3c1
Compare
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
Signed-off-by: Max Lambrecht <[email protected]>
maxlambrecht
force-pushed
the
feature/harvester-get-relationships
branch
from
2df9473 to
a004a68
Compare
Signed-off-by: Max Lambrecht <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
| } | ||
|
|
||
| // PatchRelationshipsRelationshipID accept/denied relationships requests - (PATCH /relationships/{relationshipID}) | ||
| func (h *HarvesterAPIHandlers) PatchRelationshipsRelationshipID(ctx echo.Context, relationshipID api.UUID) error { | ||
| // PatchRelationship accept/denies relationships requests - (PATCH /relationships/{relationshipID}) |
There was a problem hiding this comment.
nit picky
// PatchRelationship accepts/denies relationships requests - (PATCH /relationships/{relationshipID}
| } | ||
|
|
||
| // update the relationship consent status for the authenticated trust domain | ||
| if relationship.TrustDomainAID == authTD.ID.UUID { |
There was a problem hiding this comment.
Shouldn't we check explicitly that the relationship.TrustDomainB == authTD.ID.UUID instead of having the else statement? Could we have a case that relationship.TrustdomainA or B does not match authTD.ID.UUID? Should we return an error if the authenticated trust domain does not match A or B in the relationship?
There was a problem hiding this comment.
There is a validation above preventing that case:
if relationship.TrustDomainAID != authTD.ID.UUID && relationship.TrustDomainBID != authTD.ID.UUID {
err := fmt.Errorf("relationship doesn't belong to the authenticated trust domain")
return h.handleErrorAndLog(err, err.Error(), http.StatusUnauthorized)
}
| return h.handleErrorAndLog(err, msg, http.StatusInternalServerError) | ||
| } | ||
|
|
||
| return echoCtx.JSON(http.StatusOK, newToken) | ||
| return chttp.WriteResponse(echoCtx, newToken) | ||
| } | ||
|
|
||
| // BundleSync synchronize the status of trust bundles between server and harvester - (POST /trust-domain/{trustDomainName}/bundles/sync) |
There was a problem hiding this comment.
Nit picky
// BundleSync synchronizes the status of trust bundles between server and harvester - (POST /trust-domain/{trustDomainName}/bundles/sync)
There was a problem hiding this comment.
We should have a grammar checker 😀
There was a problem hiding this comment.
I am using spelling check in the Visual Studio.
There was a problem hiding this comment.
My IDE has a checker, but IDK why it doesn't detect that error.
Pull request check list
Affected functionality
Add Harvester API handlers for:
GET /relationshipsPATCH /relationshipsPOST /bundlePOST /bundles/syncDescription of change
Implementation of the GET relationships handler.
Implementatiojn of the POST bundle handler.
Implementatiojn of the POST bundle/sync handler.
Implementation of the PATCH relationships handler.
Redefinition of the
ConsentStatusto make it consistent across all the layers (API, business, datastore), as an enum of three possible values:pending,accepted,denied.Change the data model to reflect the
ConsentStatusproperly.Which issue this pull requests fixes
Part of the work of GLCP-39469